Skip to content

Commit ff9ec09

Browse files
authored
fix(ci): build engine package before the release self-host bundle (#4063)
release-selfhost.yml's --all bundle mode (the self-contained Docker image build) hit the same @jsonbored/gittensory-engine resolution gap ci.yml's validate-code job was fixed for: packages/gittensory-miner/lib/*.js (committed, pre-built) imports the engine package, whose dist/ is gitignored and only exists after an explicit build step. The regular selfhost.yml smoke test's narrower (non --all) build never touches that import chain, so it never caught this -- only the release pipeline's full bundle does, discovered when cutting orb-v0.4.0-beta.2 failed on this exact error.
1 parent 1deb96c commit ff9ec09

1 file changed

Lines changed: 8 additions & 0 deletions

File tree

.github/workflows/release-selfhost.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,14 @@ jobs:
9999
- name: Install deps
100100
run: npm ci --ignore-scripts
101101

102+
# #ci-engine-build-order (release pipeline): --all bundles EVERYTHING self-contained, including
103+
# packages/gittensory-miner/lib/*.js (committed, pre-built) which imports @jsonbored/gittensory-engine.
104+
# That package's dist/ is gitignored and only exists after this build step -- the regular CI smoke
105+
# test's narrower (non --all) build never hits this import chain, so it never caught the gap that
106+
# ci.yml's own validate-code job hit for ordinary backend PRs (fixed there separately).
107+
- name: Build engine package
108+
run: npm run build --workspace @jsonbored/gittensory-engine
109+
102110
- name: Build self-host bundle for release
103111
run: node scripts/build-selfhost.mjs --all
104112

0 commit comments

Comments
 (0)