Merge pull request #5997 from JSONbored/fix/config-size-gate-thresholds

fix(review): make size-gate file/line thresholds configurable

Author: JSONbored

.loopover.yml.example

@@ -202,12 +202,15 @@ gate:
     minScore: null
 
   # Oversized-PR gate. A PR at/above EITHER the file-count or line-count threshold
-  # (engine defaults, not configurable here) gets a manual-review HOLD finding —
-  # never a hard blocker; mode only turns this hold signal on or off.
-  # off | advisory | block. Default: off. Config-as-code only — no DB column or
-  # dashboard toggle; this can only be set here.
+  # gets a manual-review HOLD finding — never a hard blocker; mode only turns this
+  # hold signal on or off. off | advisory | block. Default: off. Config-as-code
+  # only — no DB column or dashboard toggle; this can only be set here.
   size:
     mode: off
+    # File-count threshold. Positive integer. Default: 10.
+    # maxFiles: 10
+    # Changed (added+deleted) line-count threshold. Positive integer. Default: 1000.
+    # maxLines: 1000
 
   # Lockfile-tamper-risk gate. Scans a changed package-lock.json diff for a
   # resolved/integrity value that changed WITHOUT the same package's version

apps/loopover-ui/public/openapi.json

@@ -9659,6 +9659,12 @@
                 "appSlug"
               ]
             }
+          },
+          "sizeGateMaxFiles": {
+            "type": "number"
+          },
+          "sizeGateMaxLines": {
+            "type": "number"
           }
         },
         "required": [

config/examples/loopover.full.yml

@@ -216,12 +216,15 @@ gate:
     minScore: null
 
   # Oversized-PR gate. A PR at/above EITHER the file-count or line-count threshold
-  # (engine defaults, not configurable here) gets a manual-review HOLD finding —
-  # never a hard blocker; mode only turns this hold signal on or off.
-  # off | advisory | block. Default: off. Config-as-code only — no DB column or
-  # dashboard toggle; this can only be set here.
+  # gets a manual-review HOLD finding — never a hard blocker; mode only turns this
+  # hold signal on or off. off | advisory | block. Default: off. Config-as-code
+  # only — no DB column or dashboard toggle; this can only be set here.
   size:
     mode: off
+    # File-count threshold. Positive integer. Default: 10.
+    # maxFiles: 10
+    # Changed (added+deleted) line-count threshold. Positive integer. Default: 1000.
+    # maxLines: 1000
 
   # Lockfile-tamper-risk gate. Scans a changed package-lock.json diff for a
   # resolved/integrity value that changed WITHOUT the same package's version

packages/loopover-engine/src/advisory/gate-advisory.ts

@@ -101,8 +101,13 @@ export type GateCheckPolicy = {
   /** PR-size HOLD (#gate-size). When set (advisory/block), a PR with >= sizeGateMaxFiles changed files OR
    *  >= sizeGateMaxLines changed (added+deleted) lines that would OTHERWISE pass is HELD for manual review — a
    *  neutral gate → "manual" verdict, never auto-merged and never a hard failure. Defaults off; thresholds default
-   *  to 10 files / 1000 lines. This is a HOLD (advisory dry-run friendly), not a close. */
+   *  to 10 files / 1000 lines when sizeGateMaxFiles/sizeGateMaxLines are unset. This is a HOLD (advisory dry-run
+   *  friendly), not a close. */
   sizeGateMode?: GateRuleMode | undefined;
+  /** PR-size HOLD file-count threshold (#gate-size). `null`/undefined ⇒ the 10-file default. */
+  sizeGateMaxFiles?: number | null | undefined;
+  /** PR-size HOLD changed-line-count threshold (#gate-size). `null`/undefined ⇒ the 1000-line default. */
+  sizeGateMaxLines?: number | null | undefined;
   /** Lockfile-tamper-risk gate (#2563). When `block`, a `lockfile_tamper_risk` finding (produced by
    *  review/lockfile-tamper.ts when a changed package-lock.json's resolved/integrity value changed without a
    *  matching package.json version bump, or points off the npm registry) becomes a hard blocker. Defaults to
@@ -388,16 +393,16 @@ function buildSizeHoldFinding(policy: GateCheckPolicy): AdvisoryFinding | null {
   if (files === undefined || files === null) files = 0;
   let lines = policy.changedLineCount;
   if (lines === undefined || lines === null) lines = 0;
-  if (
-    files < SIZE_HOLD_DEFAULT_MAX_FILES &&
-    lines < SIZE_HOLD_DEFAULT_MAX_LINES
-  )
-    return null;
+  let maxFiles = policy.sizeGateMaxFiles;
+  if (maxFiles === undefined || maxFiles === null) maxFiles = SIZE_HOLD_DEFAULT_MAX_FILES;
+  let maxLines = policy.sizeGateMaxLines;
+  if (maxLines === undefined || maxLines === null) maxLines = SIZE_HOLD_DEFAULT_MAX_LINES;
+  if (files < maxFiles && lines < maxLines) return null;
   return {
     code: "oversized_pr",
     severity: "warning",
     title: "Large change — held for manual review",
-    detail: `This PR changes ${files} file(s) / ${lines} line(s) (hold threshold: ${SIZE_HOLD_DEFAULT_MAX_FILES} files or ${SIZE_HOLD_DEFAULT_MAX_LINES} lines).`,
+    detail: `This PR changes ${files} file(s) / ${lines} line(s) (hold threshold: ${maxFiles} files or ${maxLines} lines).`,
     action: "Split this into smaller, focused PRs, or a maintainer reviews and merges it manually.",
   };
 }

packages/loopover-engine/src/focus-manifest.ts

@@ -102,6 +102,8 @@ export type FocusManifestGateConfig = {
   slopMinScore: number | null;
   slopAiAdvisory: boolean | null;
   sizeMode: GateRuleMode | null;
+  sizeMaxFiles: number | null;
+  sizeMaxLines: number | null;
   /** `gate.lockfileIntegrity` (#2563): off|advisory|block, off by default. When not off, a changed
    *  `package-lock.json` diff is scanned for a `resolved`/`integrity` change unaccompanied by a matching
    *  `package.json` version bump, or a `resolved` URL outside `registry.npmjs.org` — a `lockfile_tamper_risk`
@@ -982,6 +984,8 @@ const EMPTY_GATE_CONFIG: FocusManifestGateConfig = {
   slopMinScore: null,
   slopAiAdvisory: null,
   sizeMode: null,
+  sizeMaxFiles: null,
+  sizeMaxLines: null,
   lockfileIntegrityMode: null,
   aiReviewMode: null,
   aiReviewByok: null,
@@ -1385,6 +1389,8 @@ function parseGateConfig(value: JsonValue | undefined, warnings: string[]): Focu
     slopMinScore: normalizeOptionalScore(slopRecord?.minScore, "gate.slop.minScore", warnings),
     slopAiAdvisory: normalizeOptionalBoolean(slopRecord?.aiAdvisory, "gate.slop.aiAdvisory", warnings),
     sizeMode: normalizeOptionalGateMode(sizeRecord?.mode, "gate.size.mode", warnings),
+    sizeMaxFiles: normalizeOptionalPositiveInteger(sizeRecord?.maxFiles, "gate.size.maxFiles", warnings),
+    sizeMaxLines: normalizeOptionalPositiveInteger(sizeRecord?.maxLines, "gate.size.maxLines", warnings),
     lockfileIntegrityMode: normalizeOptionalGateMode(record.lockfileIntegrity, "gate.lockfileIntegrity", warnings),
     aiReviewMode: normalizeOptionalGateMode(aiReviewRecord?.mode, "gate.aiReview.mode", warnings),
     aiReviewByok: normalizeOptionalBoolean(aiReviewRecord?.byok, "gate.aiReview.byok", warnings),
@@ -1451,6 +1457,8 @@ function parseGateConfig(value: JsonValue | undefined, warnings: string[]): Focu
     gate.slopMinScore !== null ||
     gate.slopAiAdvisory !== null ||
     gate.sizeMode !== null ||
+    gate.sizeMaxFiles !== null ||
+    gate.sizeMaxLines !== null ||
     gate.lockfileIntegrityMode !== null ||
     gate.aiReviewMode !== null ||
     gate.aiReviewByok !== null ||
@@ -1500,7 +1508,13 @@ export function gateConfigToJson(gate: FocusManifestGateConfig): JsonValue {
     if (gate.readinessMinScore !== null) readiness.minScore = gate.readinessMinScore;
     out.readiness = readiness;
   }
-  if (gate.sizeMode !== null) out.size = { mode: gate.sizeMode };
+  if (gate.sizeMode !== null || gate.sizeMaxFiles !== null || gate.sizeMaxLines !== null) {
+    const size: Record<string, JsonValue> = {};
+    if (gate.sizeMode !== null) size.mode = gate.sizeMode;
+    if (gate.sizeMaxFiles !== null) size.maxFiles = gate.sizeMaxFiles;
+    if (gate.sizeMaxLines !== null) size.maxLines = gate.sizeMaxLines;
+    out.size = size;
+  }
   if (gate.lockfileIntegrityMode !== null) out.lockfileIntegrity = gate.lockfileIntegrityMode;
   if (gate.slopMode !== null || gate.slopMinScore !== null || gate.slopAiAdvisory !== null) {
     const slop: Record<string, JsonValue> = {};

packages/loopover-engine/src/predicted-gate.ts

@@ -308,6 +308,8 @@ export function buildPredictedGateVerdict(args: {
     // never sent to this predictor, so the size hold can only be predicted from file count (disclosed in the
     // note above) — never claim a line count this function has no way to know.
     sizeGateMode: gate.sizeMode ?? undefined,
+    sizeGateMaxFiles: gate.sizeMaxFiles ?? undefined,
+    sizeGateMaxLines: gate.sizeMaxLines ?? undefined,
     ...(hasChangedPaths
       ? {
           changedFileCount: changedPaths.length,

packages/loopover-engine/src/types/manifest-deps-types.ts

@@ -185,9 +185,16 @@ export type RepositorySettings = {
    *  only, applies to every author like every blocker). Default `off` — opt-in via .loopover.yml. */
   slopGateMode: GateRuleMode;
   /** PR-size manual-review HOLD (#gate-size). `off` (default/absent) = no size hold; `advisory`/`block` = a PR with
-   *  >= 10 changed files OR >= 1000 changed (added+deleted) lines that would otherwise pass is HELD for manual review
-   *  (neutral gate → "manual" verdict), never auto-merged and never a hard failure. Opt-in via `gate.size.mode`. */
+   *  >= sizeGateMaxFiles changed files OR >= sizeGateMaxLines changed (added+deleted) lines that would otherwise
+   *  pass is HELD for manual review (neutral gate → "manual" verdict), never auto-merged and never a hard failure.
+   *  Opt-in via `gate.size.mode`. */
   sizeGateMode?: GateRuleMode | undefined;
+  /** PR-size HOLD file-count threshold (#gate-size), config-only — set via `.loopover.yml gate.size.maxFiles`.
+   *  `undefined` ⇒ the 10-file default. */
+  sizeGateMaxFiles?: number | undefined;
+  /** PR-size HOLD changed-line-count threshold (#gate-size), config-only — set via `.loopover.yml
+   *  gate.size.maxLines`. `undefined` ⇒ the 1000-line default. */
+  sizeGateMaxLines?: number | undefined;
   /** Lockfile-tamper-risk gate (#2563). `off` (default/absent) = no scan; `advisory`/`block` = a changed
    *  `package-lock.json` whose diff changes a `resolved`/`integrity` value WITHOUT the same package's version
    *  changing in a changed `package.json`, or whose `resolved` URL points outside `registry.npmjs.org`, produces

packages/loopover-engine/src/types/predicted-gate-types.ts

@@ -292,6 +292,8 @@ export type FocusManifestGateConfig = {
   slopMinScore: number | null;
   slopAiAdvisory: boolean | null;
   sizeMode: GateRuleMode | null;
+  sizeMaxFiles: number | null;
+  sizeMaxLines: number | null;
   lockfileIntegrityMode: GateRuleMode | null;
   aiReviewMode: GateRuleMode | null;
   aiReviewByok: boolean | null;

scripts/check-docs-drift.mjs

@@ -135,6 +135,8 @@ export const SETTINGS_ALIAS_MANIFEST = [
   { field: "aiReviewOnMerge", aliases: ["onMerge"] },
   { field: "aiReviewReviewers", aliases: ["reviewers:"] },
   { field: "requireFreshRebaseWindowMinutes", aliases: ["requireFreshRebaseWindow"] },
+  { field: "sizeGateMaxFiles", aliases: ["maxFiles"] },
+  { field: "sizeGateMaxLines", aliases: ["maxLines"] },
 ];
 
 /** camelCase -> snake_case, matching the casing convention `.loopover.yml`'s `review:` block (and everything

src/openapi/schemas.ts

@@ -681,6 +681,8 @@ export const RepositorySettingsSchema = z
     qualityGateMinScore: z.number().nullable().optional(),
     slopGateMode: z.enum(["off", "advisory", "block"]),
     sizeGateMode: z.enum(["off", "advisory", "block"]).optional(),
+    sizeGateMaxFiles: z.number().optional(),
+    sizeGateMaxLines: z.number().optional(),
     lockfileIntegrityGateMode: z.enum(["off", "advisory", "block"]).optional(),
     claGateMode: z.enum(["off", "advisory", "block"]).optional(),
     claConsentPhrase: z.string().nullable().optional(),