fix(miner): classify stale checks as failures

Author: Helios531

packages/gittensory-miner/lib/ci-poller.js

@@ -60,7 +60,8 @@ function apiUrl(apiBaseUrl, path, query = "") {
 
 function githubError(response, payload) {
   const code = `github_${response.status}`;
-  const githubMessage = typeof payload?.message === "string" && payload.message.trim() ? payload.message : null;
+  const githubMessage =
+    typeof payload?.message === "string" && payload.message.trim() ? payload.message : null;
   const message = githubMessage ? `${code}: ${githubMessage}` : code;
   return Object.assign(new Error(message), { code, githubMessage });
 }
@@ -104,6 +105,7 @@ function normalizeConclusion(checkRun) {
     case "cancelled":
     case "timed_out":
     case "action_required":
+    case "stale":
     case "startup_failure":
       return "failure";
     default:
@@ -158,7 +160,10 @@ async function fetchCheckRuns(target, headSha, options) {
       ),
       options,
     );
-    const pageChecks = Array.isArray(payload?.check_runs) ? payload.check_runs.map(normalizeCheckRun) : [];
+    if (!Array.isArray(payload?.check_runs)) {
+      throw new Error("github_check_runs_malformed");
+    }
+    const pageChecks = payload.check_runs.map(normalizeCheckRun);
     checks.push(...pageChecks);
     expectedTotalCount = payloadTotalCount(payload) ?? expectedTotalCount;
     if (!hasNextLink(response) && (expectedTotalCount === null || checks.length >= expectedTotalCount)) {

test/unit/miner-ci-poller.test.ts

@@ -97,14 +97,15 @@ describe("miner CI check-run poller (#2323)", () => {
     expect(fetchFn).toHaveBeenCalledTimes(3);
   });
 
-  it("normalizes failed terminal conclusions to failure", async () => {
+  it("normalizes failed terminal conclusions, including stale, to failure", async () => {
     const fetchFn = vi
       .fn()
       .mockResolvedValueOnce(prResponse())
       .mockResolvedValueOnce(
         checksResponse([
           checkRun("validate", "completed", "success"),
           checkRun("workers", "completed", "timed_out"),
+          checkRun("expired", "completed", "stale"),
         ]),
       );
 
@@ -115,10 +116,31 @@ describe("miner CI check-run poller (#2323)", () => {
       checks: [
         { name: "validate", conclusion: "success" },
         { name: "workers", conclusion: "failure" },
+        { name: "expired", conclusion: "failure" },
       ],
     });
   });
 
+  it("treats a completed stale check run as terminal failure (regression for #2621)", async () => {
+    const fetchFn = vi
+      .fn()
+      .mockResolvedValueOnce(prResponse())
+      .mockResolvedValueOnce(checksResponse([checkRun("github-timeout", "completed", "stale")]));
+
+    await expect(
+      pollCheckRuns("acme/widgets", 7, {
+        apiBaseUrl: API,
+        fetchFn,
+        maxAttempts: 3,
+        sleepFn: vi.fn(),
+      }),
+    ).resolves.toMatchObject({
+      conclusion: "failure",
+      attempts: 1,
+      checks: [{ name: "github-timeout", conclusion: "failure" }],
+    });
+  });
+
   it("keeps pending when checks are queued or absent", async () => {
     const queuedFetch = vi
       .fn()
@@ -201,4 +223,15 @@ describe("miner CI check-run poller (#2323)", () => {
       pollCheckRuns("acme/widgets", 11, { apiBaseUrl: API, fetchFn: missingSha }),
     ).rejects.toThrow("github_pr_head_sha_missing");
   });
+
+  it("surfaces malformed check-run responses as deterministic errors", async () => {
+    const malformedChecks = vi
+      .fn()
+      .mockResolvedValueOnce(prResponse())
+      .mockResolvedValueOnce(jsonResponse({ total_count: 1, check_runs: null }));
+
+    await expect(
+      pollCheckRuns("acme/widgets", 12, { apiBaseUrl: API, fetchFn: malformedChecks }),
+    ).rejects.toThrow("github_check_runs_malformed");
+  });
 });