|
| 1 | +import { describe, expect, it } from "vitest"; |
| 2 | +import { createApp } from "../../src/api/routes"; |
| 3 | +import { createSessionForGitHubUser } from "../../src/auth/security"; |
| 4 | +import { insertNotificationDeliveryIfAbsent } from "../../src/db/repositories"; |
| 5 | +import { buildContributorPrOutcomes } from "../../src/signals/contributor-pr-outcomes"; |
| 6 | +import { createTestEnv } from "../helpers/d1"; |
| 7 | + |
| 8 | +// #6747: GET /v1/contributors/:login/pr-outcomes — the REST mirror bringing loopover_pr_outcome to the same |
| 9 | +// /v1/contributors/:login/... family its self-scoped open-pr-monitor sibling already has. The route delegates to |
| 10 | +// the shared buildContributorPrOutcomes builder (also called by the MCP tool and the CLI), so these pin the ROUTE |
| 11 | +// contract: a contributor reads only their OWN outcomes (a cross-login session is 403), an operator token may read |
| 12 | +// any login, the payload equals the builder's, and a malformed ?limit is rejected rather than clamped. |
| 13 | +const apiHeaders = (env: Env) => ({ authorization: `Bearer ${env.LOOPOVER_API_TOKEN}` }); |
| 14 | + |
| 15 | +async function seedMerged(env: Env, login: string, pullNumber: number) { |
| 16 | + await insertNotificationDeliveryIfAbsent(env, { |
| 17 | + dedupKey: `pull_request_merged:owner/repo#${pullNumber}:${login}`, |
| 18 | + channel: "badge", |
| 19 | + recipientLogin: login, |
| 20 | + eventType: "pull_request_merged", |
| 21 | + repoFullName: "owner/repo", |
| 22 | + pullNumber, |
| 23 | + title: `Merged: owner/repo#${pullNumber}`, |
| 24 | + body: `Your pull request owner/repo#${pullNumber} merged. Merged contributions strengthen your standing on owner/repo.`, |
| 25 | + deeplink: `https://github.com/owner/repo/pull/${pullNumber}`, |
| 26 | + actorLogin: login, |
| 27 | + }); |
| 28 | +} |
| 29 | + |
| 30 | +async function setup() { |
| 31 | + const app = createApp(); |
| 32 | + const env = createTestEnv({ ADMIN_GITHUB_LOGINS: "attacker" }); |
| 33 | + const { token } = await createSessionForGitHubUser(env, { login: "attacker", id: 7 }); |
| 34 | + const sessionHeaders = { authorization: `Bearer ${token}` }; |
| 35 | + return { app, env, sessionHeaders }; |
| 36 | +} |
| 37 | + |
| 38 | +describe("GET /v1/contributors/:login/pr-outcomes (#6747)", () => { |
| 39 | + it("returns the contributor's own merged-PR outcome history", async () => { |
| 40 | + const { app, env, sessionHeaders } = await setup(); |
| 41 | + await seedMerged(env, "attacker", 7); |
| 42 | + await seedMerged(env, "attacker", 8); |
| 43 | + const res = await app.request("/v1/contributors/attacker/pr-outcomes", { headers: sessionHeaders }, env); |
| 44 | + expect(res.status).toBe(200); |
| 45 | + const payload = (await res.json()) as { login: string; count: number; outcomes: Array<{ pullNumber: number; outcome: string }> }; |
| 46 | + expect(payload.login).toBe("attacker"); |
| 47 | + expect(payload.count).toBe(2); |
| 48 | + expect(payload.outcomes.every((o) => o.outcome === "merged")).toBe(true); |
| 49 | + // PARITY: the route returns exactly what the shared builder the MCP tool + CLI also call returns. |
| 50 | + expect(payload).toEqual(JSON.parse(JSON.stringify(await buildContributorPrOutcomes(env, "attacker")))); |
| 51 | + }); |
| 52 | + |
| 53 | + it("is self-scoped: a session cannot read another login's outcomes", async () => { |
| 54 | + const { app, env, sessionHeaders } = await setup(); |
| 55 | + await seedMerged(env, "victim", 1); |
| 56 | + const res = await app.request("/v1/contributors/victim/pr-outcomes", { headers: sessionHeaders }, env); |
| 57 | + expect(res.status).toBe(403); |
| 58 | + await expect(res.json()).resolves.toMatchObject({ error: "forbidden_contributor" }); |
| 59 | + }); |
| 60 | + |
| 61 | + it("lets an operator token read any login's outcomes", async () => { |
| 62 | + const { app, env } = await setup(); |
| 63 | + await seedMerged(env, "victim", 1); |
| 64 | + const res = await app.request("/v1/contributors/victim/pr-outcomes", { headers: apiHeaders(env) }, env); |
| 65 | + expect(res.status).toBe(200); |
| 66 | + await expect(res.json()).resolves.toMatchObject({ login: "victim", count: 1 }); |
| 67 | + }); |
| 68 | + |
| 69 | + it("applies a valid ?limit, and returns exactly what the builder returns for that limit", async () => { |
| 70 | + const { app, env, sessionHeaders } = await setup(); |
| 71 | + await seedMerged(env, "attacker", 7); |
| 72 | + await seedMerged(env, "attacker", 8); |
| 73 | + const res = await app.request("/v1/contributors/attacker/pr-outcomes?limit=1", { headers: sessionHeaders }, env); |
| 74 | + expect(res.status).toBe(200); |
| 75 | + const payload = (await res.json()) as { count: number }; |
| 76 | + expect(payload.count).toBe(1); |
| 77 | + expect(payload).toEqual(JSON.parse(JSON.stringify(await buildContributorPrOutcomes(env, "attacker", 1)))); |
| 78 | + }); |
| 79 | + |
| 80 | + it("rejects a malformed ?limit with 400 rather than clamping it", async () => { |
| 81 | + const { app, env, sessionHeaders } = await setup(); |
| 82 | + // One case per arm of the guard: non-integer, below range, above range, and a fractional value. |
| 83 | + for (const limit of ["abc", "0", "101", "1.5", ""]) { |
| 84 | + const res = await app.request(`/v1/contributors/attacker/pr-outcomes?limit=${limit}`, { headers: sessionHeaders }, env); |
| 85 | + expect(res.status, `limit=${limit}`).toBe(400); |
| 86 | + await expect(res.json()).resolves.toMatchObject({ error: "invalid_limit" }); |
| 87 | + } |
| 88 | + }); |
| 89 | + |
| 90 | + it("returns an empty history (not an error) for a contributor with no merged PRs", async () => { |
| 91 | + const { app, env, sessionHeaders } = await setup(); |
| 92 | + const res = await app.request("/v1/contributors/attacker/pr-outcomes", { headers: sessionHeaders }, env); |
| 93 | + expect(res.status).toBe(200); |
| 94 | + await expect(res.json()).resolves.toEqual({ login: "attacker", count: 0, outcomes: [] }); |
| 95 | + }); |
| 96 | + |
| 97 | + it("leaks no wallet/hotkey/trust-score/reward terms", async () => { |
| 98 | + const { app, env, sessionHeaders } = await setup(); |
| 99 | + await seedMerged(env, "attacker", 7); |
| 100 | + const text = JSON.stringify(await (await app.request("/v1/contributors/attacker/pr-outcomes", { headers: sessionHeaders }, env)).json()); |
| 101 | + expect(text).not.toMatch(/wallet|hotkey|coldkey|trust score|reward|payout|\$/i); |
| 102 | + }); |
| 103 | +}); |
0 commit comments