fix(miner): close deny-check bypasses

Author: JSONbored

packages/gittensory-miner/lib/deny-hooks.js

@@ -60,13 +60,24 @@ function collectInputStrings(input) {
  * rather than relying on a later caller to split the command first — a bare path-valued field still matches via
  * the whole-value candidate.
  */
+function normalizePathCandidate(candidate) {
+  const normalized = candidate
+    .replace(/\\/g, "/")
+    .replace(/\/\.(?=\/|$)/g, "")
+    .replace(/^(?:\.\/)+/, "");
+  return normalized || candidate;
+}
+
 function pathCandidates(value) {
-  const candidates = [value];
+  const candidates = new Set([value, normalizePathCandidate(value)]);
   for (const token of value.split(/\s+/)) {
     const trimmed = token.replace(/^["']+|["']+$/g, "");
-    if (trimmed && trimmed !== value) candidates.push(trimmed);
+    if (trimmed) {
+      candidates.add(trimmed);
+      candidates.add(normalizePathCandidate(trimmed));
+    }
   }
-  return candidates;
+  return [...candidates];
 }
 
 function matcherMatches(matcher, toolName) {
@@ -93,14 +104,15 @@ function ruleMatches(rule, toolName, inputStrings) {
 /**
  * The built-in house-rule deny set — a non-empty starting example a later phase can extend or replace. Mirrors the
  * forbidden-path regex in `scripts/check-mcp-package.mjs` (CI workflows, env files, secret-bearing paths, private
- * key material) and adds a conservative git force-push guard (a command carrying both `push` and `--force`).
+ * key material) and adds conservative git force-push guards (a command carrying `push` plus a force flag).
  */
 export const DEFAULT_DENY_RULES = [
   { matcher: "*", pathPattern: ".github/workflows/**", reason: "Never modify CI workflows (.github/workflows/**)." },
   { matcher: "*", pathPattern: "**/.env*", reason: "Never read or write environment files (.env*)." },
   { matcher: "*", pathPattern: "**/secret*/**", reason: "Never touch secret-bearing paths (**/secret*/**)." },
   { matcher: "*", pathPattern: "**/*private*key*", reason: "Never touch private key material (**/*private*key*)." },
   { matcher: "*", inputIncludesAll: ["push", "--force"], reason: "Never force-push (git push --force)." },
+  { matcher: "*", inputIncludesAll: ["push", "-f"], reason: "Never force-push (git push -f)." },
 ];
 
 /**

test/unit/miner-cli-deny-check.test.ts

@@ -37,6 +37,14 @@ describe("gittensory-miner hooks check command", () => {
         '{"file_path":".github/workflows/ci.yml"}',
       ]),
     ).toBe(1);
+    expect(
+      runDenyCheck([
+        "--tool",
+        "Write",
+        "--input",
+        '{"file_path":"./.github/workflows/ci.yml"}',
+      ]),
+    ).toBe(1);
     expect(error).toHaveBeenCalledWith(expect.stringContaining("CI workflows"));
   });
 

test/unit/miner-deny-hooks.test.ts

@@ -13,10 +13,11 @@ describe("evaluateDenyHooks — built-in DEFAULT_DENY_RULES", () => {
     expect(DEFAULT_DENY_RULES.length).toBeGreaterThan(0);
   });
 
-  it("blocks writing a CI workflow, allows an ordinary source path", () => {
+  it("blocks writing a CI workflow, including dot-prefixed equivalents, and allows an ordinary source path", () => {
     const blocked = evaluateDenyHooks({ name: "Write", input: { file_path: ".github/workflows/ci.yml" } });
     expect(blocked.allowed).toBe(false);
     expect(blocked.blockedBy?.reason).toContain("CI workflows");
+    expect(evaluateDenyHooks({ name: "Write", input: { file_path: "./.github/workflows/ci.yml" } }).allowed).toBe(false);
     expect(evaluateDenyHooks({ name: "Write", input: { file_path: "src/review/rag.ts" } }).allowed).toBe(true);
   });
 
@@ -46,6 +47,7 @@ describe("evaluateDenyHooks — built-in DEFAULT_DENY_RULES", () => {
 
   it("blocks a git force-push regardless of flag/subcommand order, allows a normal push", () => {
     expect(evaluateDenyHooks({ name: "Bash", input: { command: "git push --force origin main" } }).allowed).toBe(false);
+    expect(evaluateDenyHooks({ name: "Bash", input: { command: "git push -f origin main" } }).allowed).toBe(false);
     // Order-independent: both substrings present in either order.
     expect(evaluateDenyHooks({ name: "Bash", input: { command: "git --force-with-lease push" } }).allowed).toBe(false);
     expect(evaluateDenyHooks({ name: "Bash", input: { command: "git push origin main" } }).allowed).toBe(true);