Skip to content

Commit bd5dde2

Browse files
authored
fix(release): stop node-workspace from clobbering manual dependency ranges (#5740)
release-please's node-workspace plugin defaults to always-link-local: true, which force-rewrites every workspace-internal dependency's semver range on every regeneration of a release branch -- even when the current range already satisfies the sibling's version. This has repeatedly clobbered deliberate, manually-set constraints on @loopover/miner's and @loopover/mcp's @loopover/engine dependency back to a bare "*" (most recently caught by the repo's security scanner on #5730, PR #5729 before that), and separately generated a string of "empty" release PRs (mcp-v0.8.1, mcp-v1.0.1, miner-v2.0.1) that exist purely to speculatively cross-bump a dependency range ahead of the sibling's actual publish, with no real content of their own. Setting always-link-local: false (a documented top-level manifest option, confirmed against release-please's own JSON schema) makes the plugin only touch a workspace dependency when the CURRENT range no longer covers the sibling's version -- i.e. only for a genuine breaking change, which is exactly when a deliberate, manually-verified bump is warranted anyway (the judgment call this session has been making by hand every time this came up). Also fixes apps/gittensory-ui/src/lib/mcp-package.ts's MCP_PACKAGE_KNOWN_LATEST_VERSION, stale against mcp's real just-published 0.9.0 (unrelated to the config change, but blocking this branch's own gate via ui:version-audit).
1 parent 90e2f75 commit bd5dde2

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

apps/gittensory-ui/src/lib/mcp-package.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export const MCP_PACKAGE_REGISTRY_URL = `https://registry.npmjs.org/${MCP_PACKAG
88
export const MCP_PACKAGE_NPM_URL = `https://www.npmjs.com/package/${MCP_PACKAGE_NAME}`;
99
// Tracks the latest PUBLISHED release: ui:version-audit requires this to equal npm dist-tags.latest, so it is
1010
// bumped to a new version only AFTER that version publishes (never ahead of npm).
11-
export const MCP_PACKAGE_KNOWN_LATEST_VERSION = "0.7.1";
11+
export const MCP_PACKAGE_KNOWN_LATEST_VERSION = "0.9.0";
1212
export const MCP_MINIMUM_SUPPORTED_VERSION = "0.5.0";
1313

1414
export type NpmPackageMetadata = {

release-please-config.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
"include-component-in-tag": true,
2626
"separate-pull-requests": true,
2727
"pull-request-title-pattern": "chore(release): cut${component} v${version}",
28+
"always-link-local": false,
2829
"plugins": [
2930
{
3031
"type": "node-workspace",

0 commit comments

Comments
 (0)