Skip to content

Commit b86c458

Browse files
fix(ci): stop swallowing control-plane coverage failures with an unjustified || true (#8497)
The REES coverage step's identical || true is documented and justified (c8 instrumentation inflates its timing-sensitive assertions past their uninstrumented budgets). Control-plane's suite has no such timing-budget or ReDoS-guard assertions, so this looks like the shape being copied without its justification, not a verified decision. A genuine coverage-harvest failure that still writes a non-empty but incomplete/wrong lcov.info currently stays green and uploads bad data to Codecov -- exactly what the next step's existence check is meant to catch but, with the swallow in place, cannot. Verified locally: after rebuilding control-plane (stale dist), npm run control-plane:coverage exits 0 with all 201 tests passing and a clean coverage summary, confirming the swallow is safe to remove. Closes #8392
1 parent c618b9c commit b86c458

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -649,7 +649,7 @@ jobs:
649649
run: npm run control-plane:test
650650
- name: Control-plane coverage
651651
if: ${{ github.event_name == 'push' || needs.changes.outputs.controlPlane == 'true' }}
652-
run: npm run control-plane:coverage || true
652+
run: npm run control-plane:coverage
653653
- name: Verify control-plane coverage report exists
654654
if: ${{ github.event_name == 'push' || needs.changes.outputs.controlPlane == 'true' }}
655655
run: |

0 commit comments

Comments
 (0)