Commit b86c458
authored
fix(ci): stop swallowing control-plane coverage failures with an unjustified || true (#8497)
The REES coverage step's identical || true is documented and justified
(c8 instrumentation inflates its timing-sensitive assertions past their
uninstrumented budgets). Control-plane's suite has no such timing-budget
or ReDoS-guard assertions, so this looks like the shape being copied
without its justification, not a verified decision. A genuine
coverage-harvest failure that still writes a non-empty but
incomplete/wrong lcov.info currently stays green and uploads bad data to
Codecov -- exactly what the next step's existence check is meant to
catch but, with the swallow in place, cannot.
Verified locally: after rebuilding control-plane (stale dist), npm run
control-plane:coverage exits 0 with all 201 tests passing and a clean
coverage summary, confirming the swallow is safe to remove.
Closes #83921 parent c618b9c commit b86c458
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
649 | 649 | | |
650 | 650 | | |
651 | 651 | | |
652 | | - | |
| 652 | + | |
653 | 653 | | |
654 | 654 | | |
655 | 655 | | |
| |||
0 commit comments