Commit b36ea6c
committed
fix(release): correct two real bugs found in the just-shipped reconciliation job
The reconcile-stale-releases job (#7149) shipped with two real bugs,
found by actually running it live rather than trusting its "success"
conclusion:
1. dispatch_and_wait() used `gh run list --limit 1` right after `gh
workflow run` to find the just-dispatched run's ID -- unreliable, since
the new run isn't always indexed by the API yet. It grabbed a STALE,
already-completed prior run instead, reported that run's old "success",
and silently never published the new version at all (confirmed live:
packages/loopover-engine committed 3.2.3 while npm still had 3.2.2,
undetected until manually checking the actual log content -- exactly
the kind of unverified-success this whole session has been about not
repeating). Fixed by parsing the run ID directly from `gh workflow
run`'s own stdout (which prints the created run's URL), with a
timestamp-filtered `gh run list` fallback for the rare case that URL
isn't returned. Verified this against several real dispatches before
shipping.
2. mcp/miner's own isolated pack/smoke-test resolves @loopover/engine
from the real npm registry (no local workspace symlink in that bare
temp dir), and can transiently ETARGET for a short window after
engine's own publish reports success -- npm's registry is CDN-backed,
not instantly consistent across every edge node (confirmed live:
mcp and miner dispatched at the same moment against the same
already-published engine version, mcp's smoke-test hit a
already-propagated edge node and succeeded, miner's hit one that
hadn't and failed with the exact ETARGET this job exists to fix).
Added a settle delay after engine publishes plus automatic retry
(with backoff) for its dependents -- this is registry propagation
lag, not a genuine test regression, which would fail identically on
every retry instead of resolving itself.1 parent 1bd3d5f commit b36ea6c
1 file changed
Lines changed: 59 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
223 | 223 | | |
224 | 224 | | |
225 | 225 | | |
226 | | - | |
| 226 | + | |
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
| |||
258 | 258 | | |
259 | 259 | | |
260 | 260 | | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
265 | 289 | | |
266 | 290 | | |
267 | 291 | | |
| |||
272 | 296 | | |
273 | 297 | | |
274 | 298 | | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
275 | 323 | | |
276 | 324 | | |
277 | 325 | | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
278 | 330 | | |
279 | 331 | | |
280 | 332 | | |
281 | 333 | | |
282 | | - | |
| 334 | + | |
283 | 335 | | |
284 | 336 | | |
285 | | - | |
| 337 | + | |
286 | 338 | | |
287 | 339 | | |
288 | 340 | | |
| |||
0 commit comments