fix(miner): treat repeat markDone as a no-op (#2891)

Only transition portfolio rows that are not already done and return null when no row changed, matching releaseClaim semantics.

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: jony376

packages/gittensory-miner/lib/portfolio-queue.js

@@ -124,8 +124,8 @@ export function initPortfolioQueueStore(dbPath = resolvePortfolioQueueDbPath())
     )
     RETURNING *
   `);
-  const setStatusStatement = db.prepare(
-    "UPDATE miner_portfolio_queue SET status = ? WHERE repo_full_name = ? AND identifier = ?",
+  const markDoneStatement = db.prepare(
+    "UPDATE miner_portfolio_queue SET status = 'done' WHERE repo_full_name = ? AND identifier = ? AND status <> 'done'",
   );
   const listAllStatement = db.prepare(`SELECT * FROM miner_portfolio_queue ${ORDER}`);
   const listRepoStatement = db.prepare(
@@ -155,7 +155,8 @@ export function initPortfolioQueueStore(dbPath = resolvePortfolioQueueDbPath())
     markDone(repoFullName, identifier) {
       const normalizedRepo = normalizeRepoFullName(repoFullName);
       const normalizedIdentifier = normalizeIdentifier(identifier);
-      setStatusStatement.run("done", normalizedRepo, normalizedIdentifier);
+      const result = markDoneStatement.run(normalizedRepo, normalizedIdentifier);
+      if (result.changes === 0) return null;
       const row = getStatement.get(normalizedRepo, normalizedIdentifier);
       return row ? rowToEntry(row) : null;
     },

test/unit/miner-portfolio-queue.test.ts

@@ -88,6 +88,21 @@ describe("gittensory-miner portfolio/queue store (#2292)", () => {
     expect(store.markDone("o/a", "missing")).toBeNull(); // no such row → null branch
   });
 
+  it("markDone is a no-op when the item is already done", () => {
+    const store = tempStore();
+    store.enqueue({ repoFullName: "o/a", identifier: "x", priority: 1 });
+    expect(store.markDone("o/a", "x")?.status).toBe("done");
+    expect(store.markDone("o/a", "x")).toBeNull();
+  });
+
+  it("markDone transitions in-progress items to done", () => {
+    const store = tempStore();
+    store.enqueue({ repoFullName: "o/a", identifier: "work", priority: 1 });
+    expect(store.dequeueNext()?.status).toBe("in_progress");
+    expect(store.markDone("o/a", "work")?.status).toBe("done");
+    expect(store.markDone("o/a", "work")).toBeNull();
+  });
+
   it("isolates listQueue by repo and lists everything when unfiltered", () => {
     const store = tempStore();
     store.enqueue({ repoFullName: "o/a", identifier: "1", priority: 1 });