Commit 8f9f2cb
authored
fix(engine): defer repo-map's createRequire past module scope to unbreak the api Worker deploy (#4590)
* fix(engine): defer repo-map's createRequire past module scope to unbreak the api Worker deploy
createRequire(import.meta.url) ran eagerly at module load. The barrel
export in @jsonbored/gittensory-engine pulls this file into the
gittensory-api Worker bundle (via find-opportunities -> gittensory-miner's
opportunity-fanout/ranker), even though the Worker never calls
buildRepoMap. import.meta.url is undefined in that bundle's startup
context, so the eager call crashed wrangler deploy's validation step
before any request could be served. Constructing require lazily, only
when a language actually needs to be loaded, lets esbuild tree-shake the
whole unused module out of the Worker bundle instead.
* fix(miner): defer status.js's createRequire/moduleDir past module scope too
Same landmine as the repo-map.ts Worker-deploy break: an eager
createRequire(import.meta.url) and import.meta.dirname at module scope.
Not currently reachable from any bundler context, but the pattern is
exactly what broke the api Worker deploy, so close it here too before an
import chain connects it.1 parent 6fee937 commit 8f9f2cb
2 files changed
Lines changed: 29 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
24 | 32 | | |
25 | 33 | | |
26 | 34 | | |
| |||
90 | 98 | | |
91 | 99 | | |
92 | 100 | | |
93 | | - | |
| 101 | + | |
94 | 102 | | |
95 | 103 | | |
96 | 104 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
13 | | - | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
14 | 24 | | |
15 | 25 | | |
16 | 26 | | |
| |||
40 | 50 | | |
41 | 51 | | |
42 | 52 | | |
43 | | - | |
| 53 | + | |
44 | 54 | | |
45 | 55 | | |
46 | 56 | | |
| |||
75 | 85 | | |
76 | 86 | | |
77 | 87 | | |
78 | | - | |
79 | | - | |
| 88 | + | |
| 89 | + | |
80 | 90 | | |
81 | 91 | | |
82 | | - | |
| 92 | + | |
83 | 93 | | |
84 | 94 | | |
85 | 95 | | |
| |||
114 | 124 | | |
115 | 125 | | |
116 | 126 | | |
117 | | - | |
118 | | - | |
| 127 | + | |
| 128 | + | |
119 | 129 | | |
120 | 130 | | |
121 | 131 | | |
| |||
170 | 180 | | |
171 | 181 | | |
172 | 182 | | |
173 | | - | |
| 183 | + | |
174 | 184 | | |
175 | 185 | | |
176 | 186 | | |
| |||
0 commit comments