Merge pull request #7145 from shin-core/fix/command-table-role-summary-7096

fix(ui): document chat and generate-tests default roles in the command table

Author: JSONbored

apps/loopover-ui/src/components/site/command-table.test.tsx

@@ -2,6 +2,11 @@ import { render, screen, within } from "@testing-library/react";
 import { describe, expect, it } from "vitest";
 
 import { CommandTable } from "@/components/site/command-table";
+import {
+  ACTION_COMMAND_ENTRIES,
+  MAINTAINER_COMMAND_ENTRIES,
+  PUBLIC_COMMAND_ENTRIES,
+} from "@/lib/command-reference";
 
 // #6986: pinned after migrating the hand-rolled <table> markup onto the shared Table primitive --
 // confirms the real table structure, columns, and default-role lookup still render correctly.
@@ -43,4 +48,24 @@ describe("CommandTable", () => {
     render(<CommandTable title="Commands reference" entries={[]} />);
     expect(screen.getByRole("heading", { name: "Commands reference" })).toBeTruthy();
   });
+
+  it("has a DEFAULT_ROLE_SUMMARY entry for every generated command id, never the generic fallback (#7096)", () => {
+    // Drift guard: a new command added to any of the three src/github/commands.ts catalogs without a matching
+    // DEFAULT_ROLE_SUMMARY entry must fail here rather than silently render "see policy" on the live docs page.
+    const allEntries = [
+      ...PUBLIC_COMMAND_ENTRIES,
+      ...MAINTAINER_COMMAND_ENTRIES,
+      ...ACTION_COMMAND_ENTRIES,
+    ];
+    expect(allEntries.length).toBeGreaterThan(0);
+    const { container } = render(<CommandTable title="All commands" entries={allEntries} />);
+    const missing = allEntries
+      .filter((entry) => within(container).queryByText(`@loopover ${entry.id}`))
+      .filter((entry) => {
+        const row = within(container).getByText(`@loopover ${entry.id}`).closest("tr");
+        return row?.textContent?.includes("see policy");
+      })
+      .map((entry) => entry.id);
+    expect(missing).toEqual([]);
+  });
 });

apps/loopover-ui/src/components/site/command-table.tsx

@@ -10,6 +10,7 @@ import {
 const DEFAULT_ROLE_SUMMARY: Record<string, string> = {
   help: "maintainer, collaborator, confirmed_miner (default policy)",
   ask: "maintainer, collaborator, confirmed_miner",
+  chat: "maintainer, collaborator, pr_author (rate-limited; opt-in per repo)",
   preflight: "maintainer, collaborator, confirmed_miner",
   blockers: "maintainer, collaborator, confirmed_miner",
   "duplicate-check": "maintainer, collaborator, confirmed_miner",
@@ -34,6 +35,7 @@ const DEFAULT_ROLE_SUMMARY: Record<string, string> = {
   resolve: "maintainer, collaborator",
   configuration: "maintainer, collaborator",
   explain: "maintainer, collaborator",
+  "generate-tests": "maintainer",
 };
 
 export function CommandTable({