fix(review): key gate presentation on the evaluation signal, not check-run publish (#2852)

buildPublicPrIntelligenceComment and buildPublicPrPanelSignalRows derived
their local gateEnabled flag from shouldPublishReviewCheck alone, so a
reviewCheckMode: disabled repo with autonomy configured would silently
downgrade a real, evaluated gate failure to "Advisory only" / "No action"
in the public comment and panel row -- even though the same evaluation
is authoritative for the autonomous merge/close decision.

Both call sites now also treat a configured autonomy policy as enabling
gate presentation, mirroring the shouldEvaluateGate policy signal in
processors.ts, so the public surface never contradicts the decision the
engine actually made.

Author: JSONbored

src/signals/engine.ts

@@ -33,6 +33,7 @@ import { PREFLIGHT_LIMITS } from "./preflight-limits";
 import type { UnifiedCollapsible } from "../review/unified-comment";
 import { splitAiReviewNits } from "../review/ai-notes";
 import { GITTENSORY_GATE_CHECK_NAME, shouldPublishReviewCheck } from "../review/check-names";
+import { isAgentConfigured } from "../settings/autonomy";
 import { diffFilePriority } from "../review/review-diff";
 
 export type ParticipationLane = "direct_pr" | "issue_discovery" | "split" | "inactive" | "unknown";
@@ -4278,7 +4279,11 @@ export function buildPublicPrIntelligenceComment(args: {
     /* v8 ignore next -- Public findings may omit actions; public comment tests cover sanitized action inclusion. */
     ...(publicFindings.length > 0 ? publicFindings.flatMap((finding) => (finding.action ? [finding.action] : [])) : []),
   ].filter((step) => !containsPrivatePublicTerm(step));
-  const gateEnabled = shouldPublishReviewCheck(args.settings.reviewCheckMode);
+  // #2852: gate presentation follows the SAME evaluation/policy signal as shouldEvaluateGate in
+  // processors.ts (published check-run OR autonomy needs a verdict) -- not the check-run publish flag
+  // alone, so a `reviewCheckMode: disabled` repo with autonomy configured still shows its real gate
+  // result in the public comment instead of silently downgrading to "no gate at all".
+  const gateEnabled = shouldPublishReviewCheck(args.settings.reviewCheckMode) || isAgentConfigured(args.settings.autonomy);
   const hardLinkedIssueBlock =
     args.settings.linkedIssueGateMode === "block" && args.pr.linkedIssues.length === 0 && !hasClearNoIssueRationale(args.pr);
   // Duplicate-winner adjudication (#dup-winner): when the flag is ON and this PR is the earliest observed
@@ -4519,7 +4524,10 @@ export function buildPublicPrPanelSignalRows(args: {
   const readiness = buildPublicReadinessScore({ pr: args.pr, preflight: args.preflight, queueHealth: args.queueHealth, linkedDuplicatePrs: visibleLinkedDuplicatePrs, scopedOverlapCount });
   const linkedIssueResult = linkedIssuePanelResult(args.pr);
   const relatedWorkResult = relatedWorkPanelResult(visibleLinkedDuplicatePrs, scopedOverlapCount);
-  const gateEnabled = shouldPublishReviewCheck(args.settings.reviewCheckMode);
+  // #2852: see the matching comment in buildPublicPrIntelligenceComment -- gate presentation must
+  // track whether a gate is actually evaluated (check-run published OR autonomy configured), not
+  // merely whether the check-run itself is published.
+  const gateEnabled = shouldPublishReviewCheck(args.settings.reviewCheckMode) || isAgentConfigured(args.settings.autonomy);
   const hardLinkedIssueBlock = args.settings.linkedIssueGateMode === "block" && args.pr.linkedIssues.length === 0 && !hasClearNoIssueRationale(args.pr);
   // Duplicate-winner adjudication (#dup-winner): suppress the earliest known claimant's hard-duplicate block
   // (see the comment builder). Sparse legacy rows fail closed; flag-OFF keeps legacy behavior.

test/unit/signals-coverage.test.ts

@@ -831,6 +831,44 @@ describe("signal coverage edge cases", () => {
     expect(duplicateBlocked.rows.find((r) => r.key === "gateResult")!.cells[1]).not.toBe(providedGate.cells[1]);
   });
 
+  it("REGRESSION (#2852): reviewCheckMode disabled + autonomy configured still surfaces a real blocking gate result, not 'Advisory only'", () => {
+    // The gate presentation must key off whether a gate was actually EVALUATED (check-run published OR
+    // autonomy configured), not merely whether the check-run itself is published -- otherwise a disabled-
+    // check-run repo that still evaluates the gate for autonomous merge/close would silently hide a real
+    // blocking verdict from the public comment/panel, contradicting reviews/comments "must still work".
+    const directRepo = repo("owner/disabled-autonomy");
+    const collisions = buildCollisionReport(directRepo.fullName, [], []);
+    const baseArgs = {
+      repo: directRepo,
+      pr: pr(directRepo.fullName, 90, "Fix cache", { authorLogin: "miner", linkedIssues: [42], body: "Fixes #42" }),
+      profile: buildContributorProfile("miner", { login: "miner", topLanguages: ["TypeScript"], source: "github" }, [], []),
+      detection: { detected: true, source: "official_gittensor_api" as const, reason: "Confirmed.", priorPullRequests: 1, priorMergedPullRequests: 0, priorIssues: 0 },
+      queueHealth: buildQueueHealth(directRepo, [], [], collisions),
+      collisions,
+      preflight: buildPreflightResult({ repoFullName: directRepo.fullName, title: "Fix cache", body: "Fixes #42", changedFiles: ["src/cache.ts"] }, directRepo, [], []),
+      settings: { ...repoSettings(directRepo.fullName), reviewCheckMode: "disabled" as const, autonomy: { merge: "auto" as const } },
+      gate: { conclusion: "failure" as const, summary: "A configured blocker fired." },
+    };
+
+    const panel = buildPublicPrPanelSignalRows(baseArgs);
+    const gateRow = panel.rows.find((r) => r.key === "gateResult")!;
+    expect(gateRow.cells[1]).toBe("❌ Blocking");
+    expect(gateRow.cells[2]).not.toBe("Advisory only.");
+    expect(gateRow.cells[3]).not.toBe("No action.");
+
+    const comment = buildPublicPrIntelligenceComment(baseArgs);
+    expect(comment).toContain("Gittensory Orb Review Agent is blocking merge");
+    expect(comment).toContain("> [!CAUTION]");
+
+    // Sanity check: the SAME disabled-check-run repo WITHOUT autonomy configured correctly stays advisory-only
+    // (no gate evaluation happens at all, so there is nothing real to surface).
+    const noAutonomySettings = { ...baseArgs.settings, autonomy: {} };
+    const noAutonomyPanel = buildPublicPrPanelSignalRows({ ...baseArgs, settings: noAutonomySettings, gate: undefined });
+    const noAutonomyGateRow = noAutonomyPanel.rows.find((r) => r.key === "gateResult")!;
+    expect(noAutonomyGateRow.cells[2]).toBe("Advisory only.");
+    expect(noAutonomyGateRow.cells[3]).toBe("No action.");
+  });
+
   it("#dup-winner: panel hard-duplicate block is suppressed for the winner, kept for the loser, byte-identical when flag OFF", () => {
     const directRepo = repo("owner/dupwin");
     const dupIssue = issue(directRepo.fullName, 42, "Cache invalidation race");