intake(idea): accept the IdeaTarget object shapes validateIdeaSubmission already supports (#10070)

Fixes #10064

Co-authored-by: phamngocquy <phamngocquy@users.noreply.github.com>

Author: phamngocquy

apps/loopover-ui/public/openapi.json

@@ -14906,7 +14906,18 @@
             "type": "string"
           },
           "targetRepo": {
-            "type": "string"
+            "anyOf": [
+              {
+                "type": "string"
+              },
+              {
+                "type": "object",
+                "properties": {},
+                "additionalProperties": {
+                  "nullable": true
+                }
+              }
+            ]
           },
           "constraints": {
             "type": "array",
@@ -14998,7 +15009,18 @@
             "type": "string"
           },
           "targetRepo": {
-            "type": "string"
+            "anyOf": [
+              {
+                "type": "string"
+              },
+              {
+                "type": "object",
+                "properties": {},
+                "additionalProperties": {
+                  "nullable": true
+                }
+              }
+            ]
           },
           "constraints": {
             "type": "array",

packages/loopover-contract/src/api-requests.ts

@@ -165,7 +165,7 @@ export const intakeIdeaSchema = z.object({
   id: z.string().optional(),
   title: z.string().optional(),
   body: z.string().optional(),
-  targetRepo: z.string().optional(),
+  targetRepo: z.union([z.string(), z.looseObject({})]).optional(),
   constraints: z.array(z.string()).max(50).optional(),
   acceptanceHints: z.array(z.string()).max(50).optional(),
   priority: z.string().optional(),

packages/loopover-contract/src/tools/agent.ts

@@ -30,7 +30,7 @@ export const IntakeIdeaInput = z.object({
   id: z.string().optional(),
   title: z.string().optional(),
   body: z.string().optional(),
-  targetRepo: z.string().optional(),
+  targetRepo: z.union([z.string(), z.looseObject({})]).optional(),
   constraints: z.array(z.string()).max(50).optional(),
   acceptanceHints: z.array(z.string()).max(50).optional(),
   priority: z.string().optional(),

packages/loopover-engine/test/idea-intake.test.ts

@@ -1,7 +1,7 @@
 import { test } from "node:test";
 import assert from "node:assert/strict";
 
-import { validateIdeaSubmission } from "../dist/index.js";
+import { buildClaimPlan, buildTaskGraph, validateIdeaSubmission } from "../dist/index.js";
 
 // Engine-suite (node:test) coverage for validateIdeaSubmission's targetRepo resolution (#9609) so the
 // `engine` Codecov flag credits the changed lines, mirroring test/unit/idea-intake-bridge.test.ts.
@@ -21,10 +21,13 @@ test("accepts the canonical { kind: 'existing', repo } object it returns (round-
   if (r.ok) assert.deepEqual(r.idea.targetRepo, { kind: "existing", repo: "acme/widgets" });
 });
 
-test("accepts a provision object", () => {
+test("accepts a provision object and buildClaimPlan carries an empty targetRepo", () => {
   const r = validateIdeaSubmission(rawIdea({ kind: "provision" }));
   assert.equal(r.ok, true);
-  if (r.ok) assert.deepEqual(r.idea.targetRepo, { kind: "provision" });
+  if (!r.ok) return;
+  assert.deepEqual(r.idea.targetRepo, { kind: "provision" });
+  const plan = buildClaimPlan(buildTaskGraph(r.idea), r.idea.targetRepo);
+  assert.equal(plan.targetRepo, "");
 });
 
 test("rejects a malformed slug in both the string and the existing-object form", () => {

src/openapi/schemas.ts

@@ -2287,7 +2287,7 @@ export const IntakeIdeaRequestSchema = z
     id: z.string().optional(),
     title: z.string().optional(),
     body: z.string().optional(),
-    targetRepo: z.string().optional(),
+    targetRepo: z.union([z.string(), z.looseObject({})]).optional(),
     constraints: z.array(z.string()).max(50).optional(),
     acceptanceHints: z.array(z.string()).max(50).optional(),
     priority: z.string().optional(),
@@ -2322,7 +2322,7 @@ export const PlanIdeaClaimsRequestSchema = z
     id: z.string().optional(),
     title: z.string().optional(),
     body: z.string().optional(),
-    targetRepo: z.string().optional(),
+    targetRepo: z.union([z.string(), z.looseObject({})]).optional(),
     constraints: z.array(z.string()).max(50).optional(),
     acceptanceHints: z.array(z.string()).max(50).optional(),
     priority: z.string().optional(),

test/unit/contract-api-requests.test.ts

@@ -27,6 +27,7 @@ import {
   SCENARIO_MAX_LINKED_ISSUE_NUMBERS,
   SCENARIO_MAX_REPO_FULL_NAME_CHARS,
 } from "@loopover/contract";
+import { validateIdeaSubmission } from "@loopover/engine";
 import { MAX_NOTIFICATION_DELIVERY_ID_LENGTH as SRC_DELIVERY_ID, MAX_NOTIFICATION_MARK_READ_IDS as SRC_MARK_READ } from "../../src/db/repositories";
 import { MAX_FOCUS_MANIFEST_BYTES as SRC_MANIFEST_BYTES } from "../../src/signals/focus-manifest";
 import { MAX_LOCAL_SCORER_WARNING_CHARS as SRC_WARNING_CHARS, MAX_LOCAL_SCORER_WARNING_COUNT as SRC_WARNING_COUNT } from "../../src/signals/local-scorer-diagnostics";
@@ -108,6 +109,18 @@ describe("the moved schemas accept and reject what they always did (#9750)", ()
     // empty submission must REACH the handler rather than be rejected by the schema.
     expect(intakeIdeaSchema.safeParse({}).success).toBe(true);
     expect(intakeIdeaSchema.safeParse({ constraints: Array.from({ length: 51 }, () => "c") }).success).toBe(false);
+    expect(intakeIdeaSchema.safeParse({ targetRepo: { kind: "provision" } }).success).toBe(true);
+    expect(intakeIdeaSchema.safeParse({ targetRepo: { kind: "existing", repo: "acme/widgets" } }).success).toBe(true);
+    expect(intakeIdeaSchema.safeParse({ targetRepo: "acme/widgets" }).success).toBe(true);
+    expect(intakeIdeaSchema.safeParse({ targetRepo: 42 }).success).toBe(false);
+  });
+
+  it("#10064: malformed object targetRepo passes the schema but is rejected by validateIdeaSubmission", () => {
+    const body = { targetRepo: { kind: "existing" } };
+    expect(intakeIdeaSchema.safeParse(body).success).toBe(true);
+    const validated = validateIdeaSubmission(body);
+    expect(validated.ok).toBe(false);
+    if (!validated.ok) expect(validated.errors).toContain("target_repo_required");
   });
 
   it("leaves check-before-start entirely optional — the repository is the path param, not the body", () => {