Commit 5528d20
committed
fix(review): avoid a UI typecheck regression from a new agent-actions import
focus-manifest.ts is part of the UI package's typechecked closure (its
transitive deps get walked by apps/gittensory-ui's own tsc run). Importing
MAX_REVIEW_NAG_COOLDOWN_DAYS from settings/agent-actions.ts pulled that
module's own import of github/commands.ts -> utils/crypto.ts into the UI
build for the first time, exposing a pre-existing latent
Uint8Array<ArrayBufferLike>/BufferSource type mismatch in crypto.ts that
the UI's tsc had never previously reached.
Duplicates the small constant locally in focus-manifest.ts instead of
importing it, keeping db/repositories.ts's own import from agent-actions.ts
(never part of the UI closure) unaffected. Also rebases the branch's merge
commit into a linear rebase onto current main.1 parent f9526e8 commit 5528d20
1 file changed
Lines changed: 7 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | 7 | | |
9 | 8 | | |
10 | 9 | | |
| |||
742 | 741 | | |
743 | 742 | | |
744 | 743 | | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
745 | 751 | | |
746 | 752 | | |
747 | 753 | | |
| |||
0 commit comments