Skip to content

Commit 459df50

Browse files
authored
fix(signals): drop the stale v8-ignore on buildCollisionReport's pairwise loop (#2714)
codecov/patch flagged the new path-overlap guard at 66.66% because the whole pairwise loop was wrapped in a v8-ignore comment that predates real per-branch test coverage for it. Confirmed via the full unsharded suite that removing it reveals zero new gaps (engine.ts stays at 99.25%/97.94% branch, same 3 pre-existing unrelated uncovered lines) — the loop is fully exercised by the existing + new collision tests, the ignore was just stale.
1 parent 91f137d commit 459df50

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

src/signals/engine.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -842,7 +842,6 @@ export function buildCollisionReport(
842842
const items = [...pairwiseIssues.map(issueItem), ...pairwisePullRequests.map(prItem), ...pairwiseRecentMergedPullRequests.map(recentMergedItem)];
843843
const itemTerms = new Map<string, CollisionTerms>();
844844
for (const item of items) itemTerms.set(itemKey(item), collisionTerms(item));
845-
/* v8 ignore start -- Pairwise collision guards protect sparse cached rows; public collision behavior is covered by report tests. */
846845
for (let leftIndex = 0; leftIndex < items.length; leftIndex += 1) {
847846
for (let rightIndex = leftIndex + 1; rightIndex < items.length; rightIndex += 1) {
848847
const left = items[leftIndex];
@@ -891,7 +890,6 @@ export function buildCollisionReport(
891890
});
892891
}
893892
}
894-
/* v8 ignore stop */
895893

896894
const clusterList = [...clusters.values()].sort((left, right) => riskRank(right.risk) - riskRank(left.risk));
897895
const report = {

0 commit comments

Comments
 (0)