Commit 43a71a7
committed
test(signals): cover decidePublicSurface's oss_maintainer + not_checked willLabel fallback (#8324)
The inline fallback disjunct in willLabel's computation (settings.publicAudienceMode
=== "oss_maintainer" && input.minerStatus === "not_checked" && settings.autoLabelEnabled
&& (comment_and_label || label_only)) had zero test coverage despite decidePublicSurface's
own doc comment claiming it's the single source of truth shared by the live webhook
processor and the maintainer-facing dry-run preview. Adds four tests covering every
combination of autoLabelEnabled and publicSurface for this branch: labels for
comment_and_label and label_only, does not label for comment_only or when
autoLabelEnabled is false. shouldApplyPrLabel itself always returns false for
oss_maintainer + any non-confirmed status, so willLabel: true in these tests is
exclusively exercising the inline fallback, not double-satisfied by the imported
function. Pure test-addition, no production code changed.1 parent f1b5cc1 commit 43a71a7
1 file changed
Lines changed: 41 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
86 | 127 | | |
87 | 128 | | |
88 | 129 | | |
| |||
0 commit comments