Commit 30e77ba
authored
Investigated merging signals.test.ts + signals-v2.test.ts + signals-coverage.test.ts
per #8576. Found no real duplication to dedupe: across all ~148 top-level test
cases in the trio, zero title collisions, and spot-checking similarly-named
pairs (e.g. "audits configured labels..." vs "audits label ordering...")
confirmed they test different functions entirely (buildConfigQuality vs
buildLabelAudit). signals-v2.test.ts genuinely covers newer builders
(buildCollisionEdges, buildContributorPatternReport, buildMaintainerPacket,
buildRoleContext) absent from signals.test.ts -- organic API growth, not
lazy duplication.
A forced 6,255-line merge would be pure structural churn with real risk
(import/identifier collisions across three large files) and no dedup
benefit, so scoped this down to the honest, warranted action: only
signals-coverage.test.ts actually matches the epic's *-coverage.test.ts
anti-pattern (the file #8580's guard will block going forward). Renamed
to signals-edge-cases.test.ts, retitled its top-level describe, and
updated the three cross-file comments that referenced the old filename
(feasibility-gate-branches.test.ts, queue-4.test.ts, signals/engine.ts).
signals.test.ts and signals-v2.test.ts are left untouched.
1 parent 35b934e commit 30e77ba
4 files changed
Lines changed: 9 additions & 4 deletions
File tree
- packages/loopover-engine/src/signals
- test/unit
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4520 | 4520 | | |
4521 | 4521 | | |
4522 | 4522 | | |
4523 | | - | |
| 4523 | + | |
4524 | 4524 | | |
4525 | 4525 | | |
4526 | 4526 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2950 | 2950 | | |
2951 | 2951 | | |
2952 | 2952 | | |
2953 | | - | |
| 2953 | + | |
2954 | 2954 | | |
2955 | 2955 | | |
2956 | 2956 | | |
| |||
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
60 | 65 | | |
61 | 66 | | |
62 | 67 | | |
| |||
0 commit comments