Commit 22c8763
committed
fix(mcp,typecheck): prune the imports the contract migration orphaned, and make the root typecheck catch them
The stdio migration left ~40 imports and shape constants unreferenced once every
tool started resolving its schemas through getToolContract. @loopover/mcp's own
tsconfig sets noUnusedLocals, so its package build failed on all of them -- twice
-- while 'npm run typecheck' and the full unit suite stayed green locally.
That gap is the real bug, and it is fixed here rather than worked around: the
root 'typecheck' script now runs the root tsconfig AND each package whose config
is stricter than it (@loopover/contract, @loopover/mcp, @loopover/miner). A bare
'npm run typecheck' now covers the same surface CI's build steps do, so this
class of failure cannot pass locally and fail in CI again.
Also defaults preflight_local_diff's baseRef at the call site. It is optional in
the shared contract input -- the remote server has no checkout to read -- so the
local diff collector needs the 'HEAD' default the stdio-only shape used to bake
into the schema.1 parent 56d16f0 commit 22c8763
3 files changed
Lines changed: 22 additions & 267 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
101 | 103 | | |
102 | 104 | | |
103 | 105 | | |
| |||
0 commit comments