Skip to content

Commit 22c8763

Browse files
committed
fix(mcp,typecheck): prune the imports the contract migration orphaned, and make the root typecheck catch them
The stdio migration left ~40 imports and shape constants unreferenced once every tool started resolving its schemas through getToolContract. @loopover/mcp's own tsconfig sets noUnusedLocals, so its package build failed on all of them -- twice -- while 'npm run typecheck' and the full unit suite stayed green locally. That gap is the real bug, and it is fixed here rather than worked around: the root 'typecheck' script now runs the root tsconfig AND each package whose config is stricter than it (@loopover/contract, @loopover/mcp, @loopover/miner). A bare 'npm run typecheck' now covers the same surface CI's build steps do, so this class of failure cannot pass locally and fail in CI again. Also defaults preflight_local_diff's baseRef at the call site. It is optional in the shared contract input -- the remote server has no checkout to read -- so the local diff collector needs the 'HEAD' default the stdio-only shape used to bake into the schema.
1 parent 56d16f0 commit 22c8763

3 files changed

Lines changed: 22 additions & 267 deletions

File tree

package-lock.json

Lines changed: 16 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,9 @@
9797
"changelog:check:mcp": "node --experimental-strip-types scripts/check-changelog.ts --mcp",
9898
"mcp:release-due": "tsx scripts/check-mcp-release-due.ts --json",
9999
"mcp:release-candidate": "tsx scripts/check-mcp-release-candidate.ts",
100-
"typecheck": "tsc --noEmit",
100+
"typecheck": "npm run typecheck:root && npm run typecheck:packages",
101+
"typecheck:root": "tsc --noEmit",
102+
"typecheck:packages": "tsc -p packages/loopover-contract/tsconfig.json --noEmit && tsc -p packages/loopover-mcp/tsconfig.json --noEmit && tsc -p packages/loopover-miner/tsconfig.json --noEmit",
101103
"check-node-version": "node --experimental-strip-types scripts/check-node-version.ts",
102104
"pretest": "npm run check-node-version",
103105
"test": "vitest run",

0 commit comments

Comments
 (0)