feat(review): surface generate-tests command inline in the review comment (#4583)

manifest_missing_tests already renders in ORB's own comment, but nothing there
told a maintainer the @gittensory generate-tests command exists -- mirrors
CodeRabbit's inline "Generate unit tests" walkthrough checkbox instead of a
separate dashboard toggle, gated on the same e2eTests feature check the
#4196 auto-trigger already uses so an unconfigured repo never sees a command
that would just bounce.

Fixes #4583

Author: JSONbored

src/queue/processors.ts

@@ -1029,10 +1029,16 @@ const PUBLIC_MANIFEST_POLICY_FINDING_OVERRIDES: Partial<
   },
 };
 
+// #4583: surfaces the AI test-generation command right where a maintainer already sees the missing-coverage
+// finding, mirroring CodeRabbit's inline "Generate unit tests" walkthrough checkbox instead of requiring the
+// maintainer to already know the `@gittensory generate-tests` command exists from documentation alone.
+const E2E_TEST_GEN_CTA = "Maintainers can also comment `@gittensory generate-tests` for an AI-generated Playwright test.";
+
 export function publicSafeManifestPolicyFinding(
   finding: FocusManifestFinding,
+  options: { e2eTestGenAvailable?: boolean } = {},
 ): AdvisoryFinding {
-  return {
+  const base: AdvisoryFinding = {
     code: finding.code,
     severity: finding.severity,
     title: finding.title,
@@ -1043,6 +1049,16 @@ export function publicSafeManifestPolicyFinding(
     // private blocked-path globs / test expectations; codes absent from the table keep their already-generic text.
     ...PUBLIC_MANIFEST_POLICY_FINDING_OVERRIDES[finding.code],
   };
+  // Only appended when e2eTests is actually enabled for this repo (the SAME resolveConvergedFeature check the
+  // #4196 auto-trigger already gates on), so an unconfigured repo is never told about a command that would just
+  // bounce with "not enabled" -- and only for the missing-tests finding, the one case where the command is a
+  // directly relevant next step rather than noise on an unrelated finding. base.action is always defined here
+  // (PUBLIC_MANIFEST_POLICY_FINDING_OVERRIDES.manifest_missing_tests always sets one), the same always-populated
+  // guarantee the v8-ignore above already documents for this code path.
+  if (finding.code === "manifest_missing_tests" && options.e2eTestGenAvailable) {
+    return { ...base, action: `${base.action} ${E2E_TEST_GEN_CTA}` };
+  }
+  return base;
 }
 
 export async function processJob(env: Env, message: JobMessage): Promise<void> {
@@ -9442,9 +9458,14 @@ async function maybePublishPrPublicSurface(
       // Keep deterministic manifest policy findings independent from AI-review eligibility: ignored authors
       // suppress review/public output only, never maintainer-configured gate blockers or their downstream triggers.
       const policyFindings = guidance.findings;
+      // Computed once and reused below for the #4196 auto-trigger check -- same feature gate, one call. Also
+      // feeds #4583's inline CTA so the missing-tests finding surfaces `@gittensory generate-tests` right in
+      // ORB's own comment (mirrors CodeRabbit's inline walkthrough checkbox) only when the command would
+      // actually work for this repo, never as noise on a repo that hasn't opted in.
+      const e2eTestGenAvailable = resolveConvergedFeature(env, manifest, "e2eTests", repoFullName);
       for (const finding of policyFindings) {
         if (!policyCodes.has(finding.code)) continue;
-        advisory.findings.push(publicSafeManifestPolicyFinding(finding));
+        advisory.findings.push(publicSafeManifestPolicyFinding(finding, { e2eTestGenAvailable }));
       }
       // E2E test-generation auto-trigger (#4196, part of the #4189 epic): promotes the deterministic
       // manifest_missing_tests finding above from advisory-only text into an actual trigger for #4192/#4194's
@@ -9454,7 +9475,7 @@ async function maybePublishPrPublicSurface(
       // tests" from scratch, per the issue's own requirement -- this is why the auto-trigger lives inside this
       // exact manifestPolicyGateMode-gated block instead of a parallel code path: that is the only place this
       // finding is computed at all today.
-      if (pr.headSha && policyFindings.some((finding) => finding.code === "manifest_missing_tests") && resolveConvergedFeature(env, manifest, "e2eTests", repoFullName)) {
+      if (pr.headSha && policyFindings.some((finding) => finding.code === "manifest_missing_tests") && e2eTestGenAvailable) {
         const e2eTargetKey = `${repoFullName}#${pr.number}`;
         // Double-generation guard: an unchanged head SHA re-entering this pass (a re-review/sweep tick, not a
         // new push) must never re-spend an LLM call or repost a duplicate suggestion. A genuinely NEW push

test/unit/public-safe-manifest-finding.test.ts

@@ -33,4 +33,33 @@ describe("publicSafeManifestPolicyFinding", () => {
     expect(safe.detail).toBe(finding.detail);
     expect(safe.action).toBe(finding.action);
   });
+
+  // #4583: surfaces `@gittensory generate-tests` inline in the SAME comment as the missing-coverage finding
+  // (mirrors CodeRabbit's inline walkthrough checkbox), gated on the caller-resolved e2eTests feature state.
+  it("appends the generate-tests CTA to the missing-tests finding when e2e test generation is available", () => {
+    const finding: FocusManifestFinding = {
+      code: "manifest_missing_tests",
+      severity: "warning",
+      title: "Maintainer test expectations unmet",
+      detail: "Maintainer expects test evidence: run the private fuzz suite.",
+      action: "Add or update tests for the private fuzz suite.",
+    };
+    const safe = publicSafeManifestPolicyFinding(finding, { e2eTestGenAvailable: true });
+    expect(safe.action).toBe(
+      "Add regression/invariant coverage, update relevant tests, or attach passing validation output that satisfies the repo's configured expectations. Maintainers can also comment `@gittensory generate-tests` for an AI-generated Playwright test.",
+    );
+  });
+
+  it("never appends the generate-tests CTA to a finding other than manifest_missing_tests, even when e2e test generation is available", () => {
+    const finding: FocusManifestFinding = {
+      code: "manifest_linked_issue_required",
+      severity: "warning",
+      title: "Maintainer requires a linked issue",
+      detail: "This repo's maintainer focus manifest requires every PR to reference a tracked issue.",
+      action: "Link the relevant issue (for example `Closes #123`) before opening the PR.",
+    };
+    const safe = publicSafeManifestPolicyFinding(finding, { e2eTestGenAvailable: true });
+    expect(safe.action).toBe(finding.action);
+    expect(safe.action).not.toContain("generate-tests");
+  });
 });