Skip to content

Commit 16fa59b

Browse files
authored
fix(ci): build mcp/miner before test:coverage in test:ci (#7873)
npm run test:ci built @loopover/mcp and @loopover/miner (build:mcp/ build:miner) after test:coverage, but packages/loopover-mcp and packages/loopover-miner ship .ts source only -- bin/*.js and lib/*.js are gitignored. Every mcp-cli-*/miner-* test that spawns the compiled CLI via StdioClientTransport with a hardcoded bin/loopover-mcp.js or bin/loopover-miner.js path needs those binaries to already exist on disk, so a fresh checkout's local test:coverage step failed with McpError: MCP error -32000: Connection closed (root cause: MODULE_NOT_FOUND on the missing compiled bin). CI's own validate-tests job already builds engine, MCP, and miner before its "Test with coverage" step -- only the local composite script was out of order. Move build:mcp/build:miner next to the already-correctly-ordered engine/discovery-index builds, ahead of typecheck and test:coverage, matching CI. test:mcp-pack/test:miner-pack keep their existing position: they still run after their respective builds, just much earlier in the pipeline now. Verified by deleting the gitignored mcp/miner build artifacts from a clean state to reproduce the failure, then confirming the corrected order builds both binaries before test:coverage runs and the full local gate (npm run test:ci) passes end to end.
1 parent 283fb8f commit 16fa59b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
"test:smoke:browser:install": "playwright install chromium",
111111
"test:smoke:browser": "node --experimental-strip-types scripts/smoke-ui-browser.ts",
112112
"pretest:ci": "npm run check-node-version",
113-
"test:ci": "git diff --check && npm run actionlint && npm run lint:composite-actions && npm run db:migrations:check && npm run db:schema-drift:check && npm run selfhost:env-reference:check && npm run miner:env-reference:check && npm run selfhost:validate-observability && npm run cf-typegen:check && npm run build --workspace @loopover/engine && npm run build --workspace @loopover/discovery-index && npm run typecheck && npm run test:coverage && npm run test:engine-parity && npm run test:live-gate-parity && npm run test:driver-parity && npm run test --workspace @loopover/engine && npm run test:workers && npm run build:mcp && npm run test:mcp-pack && npm run build:miner && npm run test:miner-pack && npm run test:miner-deployment-docs-audit && npm run rees:test && npm run ui:openapi:check && npm run ui:openapi:settings-parity && npm run ui:version-audit && npm run docs:drift-check && npm run branding-drift:check && npm run manifest:drift-check && npm run engine-parity:drift-check && npm run engines-nvmrc:check && npm run release-manifest:sync:check && npm run command-reference:check && npm run ui:lint && npm run ui:typecheck && npm run ui:test && npm run ui:build",
113+
"test:ci": "git diff --check && npm run actionlint && npm run lint:composite-actions && npm run db:migrations:check && npm run db:schema-drift:check && npm run selfhost:env-reference:check && npm run miner:env-reference:check && npm run selfhost:validate-observability && npm run cf-typegen:check && npm run build --workspace @loopover/engine && npm run build --workspace @loopover/discovery-index && npm run build:mcp && npm run build:miner && npm run typecheck && npm run test:coverage && npm run test:engine-parity && npm run test:live-gate-parity && npm run test:driver-parity && npm run test --workspace @loopover/engine && npm run test:workers && npm run test:mcp-pack && npm run test:miner-pack && npm run test:miner-deployment-docs-audit && npm run rees:test && npm run ui:openapi:check && npm run ui:openapi:settings-parity && npm run ui:version-audit && npm run docs:drift-check && npm run branding-drift:check && npm run manifest:drift-check && npm run engine-parity:drift-check && npm run engines-nvmrc:check && npm run release-manifest:sync:check && npm run command-reference:check && npm run ui:lint && npm run ui:typecheck && npm run ui:test && npm run ui:build",
114114
"test:release": "npm run test:ci && npm run changelog:check",
115115
"test:release:mcp": "npm run test:ci",
116116
"test:watch": "vitest",

0 commit comments

Comments
 (0)