Skip to content

Commit 1402323

Browse files
fix(ci): add explicit failure check to redis readiness loop (#7842)
1 parent fa21f3e commit 1402323

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

.github/workflows/selfhost.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,10 +145,12 @@ jobs:
145145
docker network create gt-smoke
146146
docker run -d --name gt-redis --network gt-smoke redis:7-alpine
147147
trap 'docker rm -f gt gt-redis >/dev/null 2>&1 || true; docker network rm gt-smoke >/dev/null 2>&1 || true' EXIT
148+
ok=0
148149
for _ in $(seq 1 30); do
149-
if docker exec gt-redis redis-cli ping | grep -q PONG; then break; fi
150+
if docker exec gt-redis redis-cli ping | grep -q PONG; then ok=1; break; fi
150151
sleep 1
151152
done
153+
if [ "$ok" != "1" ]; then echo "::error::redis did not become ready"; docker logs gt-redis; exit 1; fi
152154
docker run -d --name gt --network gt-smoke -p 8787:8787 \
153155
-e REDIS_URL=redis://gt-redis:6379 \
154156
-e SELFHOST_SETUP_TOKEN=selfhost-ci-setup-token \

0 commit comments

Comments
 (0)