|
| 1 | +import { afterEach, describe, expect, it, vi } from "vitest"; |
| 2 | +import { |
| 3 | + recordConfiguredGateBlockerSignals, |
| 4 | + type GateCheckPolicy, |
| 5 | +} from "../../src/rules/advisory"; |
| 6 | +import * as signalTrackingWire from "../../src/review/signal-tracking-wire"; |
| 7 | +import { createSignalStore } from "../../src/review/signal-tracking-wire"; |
| 8 | +import type { Advisory, AdvisoryFinding } from "../../src/types"; |
| 9 | +import { createTestEnv } from "../helpers/d1"; |
| 10 | + |
| 11 | +function finding(over: Partial<AdvisoryFinding> & Pick<AdvisoryFinding, "code">): AdvisoryFinding { |
| 12 | + return { |
| 13 | + title: over.title ?? over.code, |
| 14 | + severity: over.severity ?? "warning", |
| 15 | + detail: over.detail ?? `${over.code} detail`, |
| 16 | + action: over.action ?? "fix it", |
| 17 | + ...over, |
| 18 | + }; |
| 19 | +} |
| 20 | + |
| 21 | +function advisory(findings: AdvisoryFinding[]): Advisory { |
| 22 | + return { |
| 23 | + id: "advisory-8104", |
| 24 | + targetType: "pull_request", |
| 25 | + targetKey: "owner/repo#7", |
| 26 | + repoFullName: "owner/repo", |
| 27 | + pullNumber: 7, |
| 28 | + headSha: "abc", |
| 29 | + conclusion: "neutral", |
| 30 | + severity: "warning", |
| 31 | + title: "advisory", |
| 32 | + summary: `${findings.length} finding(s)`, |
| 33 | + findings, |
| 34 | + generatedAt: "2026-07-22T00:00:00.000Z", |
| 35 | + }; |
| 36 | +} |
| 37 | + |
| 38 | +const blockAi: GateCheckPolicy = { aiReviewGateMode: "block" }; |
| 39 | +const blockLinked: GateCheckPolicy = { linkedIssueGateMode: "block" }; |
| 40 | +const blockSatisfaction: GateCheckPolicy = { linkedIssueSatisfactionGateMode: "block" }; |
| 41 | + |
| 42 | +describe("recordConfiguredGateBlockerSignals (#8104)", () => { |
| 43 | + afterEach(() => { |
| 44 | + vi.restoreAllMocks(); |
| 45 | + }); |
| 46 | + |
| 47 | + it("records a fired signal for ai_consensus_defect when it is a configured gate blocker", async () => { |
| 48 | + const env = createTestEnv(); |
| 49 | + await recordConfiguredGateBlockerSignals( |
| 50 | + env, |
| 51 | + advisory([finding({ code: "ai_consensus_defect", confidence: 0.95 })]), |
| 52 | + blockAi, |
| 53 | + "owner/repo", |
| 54 | + 7, |
| 55 | + ); |
| 56 | + const history = await createSignalStore(env).queryRuleHistory("ai_consensus_defect", 0); |
| 57 | + expect(history.fired).toHaveLength(1); |
| 58 | + expect(history.fired[0]).toMatchObject({ |
| 59 | + ruleId: "ai_consensus_defect", |
| 60 | + targetKey: "owner/repo#7", |
| 61 | + outcome: "warning", |
| 62 | + metadata: { confidence: 0.95 }, |
| 63 | + }); |
| 64 | + }); |
| 65 | + |
| 66 | + it("records a fired signal for ai_review_split when it is a configured gate blocker", async () => { |
| 67 | + const env = createTestEnv(); |
| 68 | + await recordConfiguredGateBlockerSignals( |
| 69 | + env, |
| 70 | + advisory([finding({ code: "ai_review_split", severity: "critical" })]), |
| 71 | + blockAi, |
| 72 | + "owner/repo", |
| 73 | + 7, |
| 74 | + ); |
| 75 | + const history = await createSignalStore(env).queryRuleHistory("ai_review_split", 0); |
| 76 | + expect(history.fired).toHaveLength(1); |
| 77 | + expect(history.fired[0]).toMatchObject({ |
| 78 | + ruleId: "ai_review_split", |
| 79 | + targetKey: "owner/repo#7", |
| 80 | + outcome: "critical", |
| 81 | + }); |
| 82 | + expect(history.fired[0]?.metadata).toBeUndefined(); |
| 83 | + }); |
| 84 | + |
| 85 | + it("records a fired signal for a deterministic code (secret_leak)", async () => { |
| 86 | + const env = createTestEnv(); |
| 87 | + await recordConfiguredGateBlockerSignals( |
| 88 | + env, |
| 89 | + advisory([finding({ code: "secret_leak", severity: "critical" })]), |
| 90 | + {}, |
| 91 | + "owner/repo", |
| 92 | + 7, |
| 93 | + ); |
| 94 | + const history = await createSignalStore(env).queryRuleHistory("secret_leak", 0); |
| 95 | + expect(history.fired).toHaveLength(1); |
| 96 | + expect(history.fired[0]).toMatchObject({ |
| 97 | + ruleId: "secret_leak", |
| 98 | + targetKey: "owner/repo#7", |
| 99 | + outcome: "critical", |
| 100 | + }); |
| 101 | + }); |
| 102 | + |
| 103 | + it("records a fired signal for missing_linked_issue when linkedIssueGateMode is block", async () => { |
| 104 | + const env = createTestEnv(); |
| 105 | + await recordConfiguredGateBlockerSignals( |
| 106 | + env, |
| 107 | + advisory([finding({ code: "missing_linked_issue" })]), |
| 108 | + blockLinked, |
| 109 | + "owner/repo", |
| 110 | + 7, |
| 111 | + ); |
| 112 | + expect((await createSignalStore(env).queryRuleHistory("missing_linked_issue", 0)).fired).toHaveLength(1); |
| 113 | + }); |
| 114 | + |
| 115 | + it("records NO fired signal for linked_issue_scope_mismatch even when it is a configured blocker (#8101 owns it)", async () => { |
| 116 | + const env = createTestEnv(); |
| 117 | + await recordConfiguredGateBlockerSignals( |
| 118 | + env, |
| 119 | + advisory([finding({ code: "linked_issue_scope_mismatch" }), finding({ code: "secret_leak", severity: "critical" })]), |
| 120 | + blockSatisfaction, |
| 121 | + "owner/repo", |
| 122 | + 7, |
| 123 | + ); |
| 124 | + expect((await createSignalStore(env).queryRuleHistory("linked_issue_scope_mismatch", 0)).fired).toEqual([]); |
| 125 | + expect((await createSignalStore(env).queryRuleHistory("secret_leak", 0)).fired).toHaveLength(1); |
| 126 | + }); |
| 127 | + |
| 128 | + it("records NO fired signal when isConfiguredGateBlocker returns false", async () => { |
| 129 | + const env = createTestEnv(); |
| 130 | + // missing_linked_issue defaults to advisory — not a configured blocker. |
| 131 | + await recordConfiguredGateBlockerSignals( |
| 132 | + env, |
| 133 | + advisory([finding({ code: "missing_linked_issue" })]), |
| 134 | + { linkedIssueGateMode: "advisory" }, |
| 135 | + "owner/repo", |
| 136 | + 7, |
| 137 | + ); |
| 138 | + expect((await createSignalStore(env).queryRuleHistory("missing_linked_issue", 0)).fired).toEqual([]); |
| 139 | + }); |
| 140 | + |
| 141 | + it("uses outcome 'blocker' when finding.severity is missing (nullish coalescing arm)", async () => { |
| 142 | + const env = createTestEnv(); |
| 143 | + const noSeverity = finding({ code: "secret_leak" }); |
| 144 | + delete (noSeverity as { severity?: AdvisoryFinding["severity"] }).severity; |
| 145 | + await recordConfiguredGateBlockerSignals(env, advisory([noSeverity]), {}, "owner/repo", 7); |
| 146 | + expect((await createSignalStore(env).queryRuleHistory("secret_leak", 0)).fired[0]?.outcome).toBe("blocker"); |
| 147 | + }); |
| 148 | + |
| 149 | + it("degrades silently when the SignalStore write rejects: nothing throws", async () => { |
| 150 | + vi.spyOn(signalTrackingWire, "createSignalStore").mockReturnValue({ |
| 151 | + recordRuleFired: async () => { |
| 152 | + throw new Error("signal store down"); |
| 153 | + }, |
| 154 | + recordHumanOverride: async () => undefined, |
| 155 | + queryRuleHistory: async () => ({ fired: [], overrides: [] }), |
| 156 | + }); |
| 157 | + await expect( |
| 158 | + recordConfiguredGateBlockerSignals( |
| 159 | + createTestEnv(), |
| 160 | + advisory([finding({ code: "secret_leak", severity: "critical" })]), |
| 161 | + {}, |
| 162 | + "owner/repo", |
| 163 | + 7, |
| 164 | + ), |
| 165 | + ).resolves.toBeUndefined(); |
| 166 | + }); |
| 167 | +}); |
0 commit comments