-
-
Notifications
You must be signed in to change notification settings - Fork 67
feat(enrichment): empty-catch / error-swallow analyzer #2014
Copy link
Copy link
Closed
Labels
gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.help wantedExtra attention is neededExtra attention is needed
Description
Metadata
Metadata
Assignees
Labels
gittensor:featureGittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.Gittensor-scored feature linked to a feature issue — scores a 0.25x multiplier.help wantedExtra attention is neededExtra attention is needed
Projects
StatusShow more project fields
Done
New REES local analyzer that flags newly-added catch blocks that swallow the error (empty body, or body that neither rethrows, logs, nor references the caught binding) — a top source of silent failures the headless reviewer often misses. Pure compute over added diff lines, no network, no GitHub token. Follows the established actions-pin.ts pattern exactly.
Deliverables
ErrorSwallowFindinginterface ({ file, line, kind: 'empty-catch'|'unused-binding'|'return-null' }) and anerrorSwallow?key toBriefFindingsin review-enrichment/src/types.tscatch (e) {}/ catch blocks that never reference the binding or rethrow; scoped to JS/TS/Python (except: pass) source files; cap findings via amaxFindingslimitfile:linelistReferences
review-enrichment/src/analyzers/actions-pin.ts (pure-local pattern to copy)review-enrichment/src/analyzers/secret/descriptor.ts (inline render() pattern)review-enrichment/src/analyzers/registry.ts:158-175 (redos descriptor as a local-analyzer template)review-enrichment/src/types.ts:289-311 (BriefFindings)review-enrichment/src/analyzers/types.ts (AnalyzerDescriptor contract)Part of #1499.
size: S · gittensor:feature