retest

Author: =

src/services/queue-trends.ts

@@ -88,15 +88,16 @@ function buildWindow(windowDays: 7 | 14 | 30, totals: RepoGithubTotalsSnapshotRe
   const targetMs = latestMs - windowDays * 24 * 60 * 60 * 1000;
   const baseline = [...totals].reverse().find((snapshot) => Date.parse(snapshot.fetchedAt) <= targetMs);
   if (!baseline) return unavailableWindow(windowDays, `Need at least ${windowDays} days of totals history.`);
-  const observedDays = Math.max(0, round((latestMs - Date.parse(baseline.fetchedAt)) / (24 * 60 * 60 * 1000)));
+  // Baseline is the newest snapshot at or before (latest - windowDays), so observedDays is always >= windowDays.
+  const observedDays = round((latestMs - Date.parse(baseline.fetchedAt)) / (24 * 60 * 60 * 1000));
   const mergedPullRequests = Math.max(0, latest.mergedPullRequestsTotal - baseline.mergedPullRequestsTotal);
   const closedUnmergedPullRequests = Math.max(0, latest.closedUnmergedPullRequestsTotal - baseline.closedUnmergedPullRequestsTotal);
   const latestQueue = latestQueuePoint(queuePoints);
   const baselineQueue = latestQueue ? baselineQueuePoint(queuePoints, latestQueue.generatedAt, windowDays) : null;
   const stalePullRequestRate = latestQueue ? staleRate(latestQueue) : null;
   const baselineStaleRate = baselineQueue ? staleRate(baselineQueue) : null;
   const duplicateTrend = latestQueue && baselineQueue ? latestQueue.collisionClusters - baselineQueue.collisionClusters : null;
-  const reviewVelocityPerDay = computeReviewVelocityPerDay(mergedPullRequests, closedUnmergedPullRequests, observedDays);
+  const reviewVelocityPerDay = round((mergedPullRequests + closedUnmergedPullRequests) / observedDays);
   const pullRequestGrowth = latest.openPullRequestsTotal - baseline.openPullRequestsTotal;
   return {
     windowDays,
@@ -112,16 +113,10 @@ function buildWindow(windowDays: 7 | 14 | 30, totals: RepoGithubTotalsSnapshotRe
     stalePullRequestRate,
     stalePullRequestRateDelta: stalePullRequestRate !== null && baselineStaleRate !== null ? round(stalePullRequestRate - baselineStaleRate) : null,
     duplicateTrend,
-    summary: `${windowDays}d trend: PR queue ${signed(pullRequestGrowth)}, review velocity ${reviewVelocityPerDay === null ? "n/a" : `${reviewVelocityPerDay}/day`}.`,
+    summary: `${windowDays}d trend: PR queue ${signed(pullRequestGrowth)}, review velocity ${reviewVelocityPerDay}/day.`,
   };
 }
 
-/** Returns null when the observation window spans zero days (avoids divide-by-zero / fabricated velocity). */
-export function computeReviewVelocityPerDay(mergedPullRequests: number, closedUnmergedPullRequests: number, observedDays: number): number | null {
-  if (observedDays === 0) return null;
-  return round((mergedPullRequests + closedUnmergedPullRequests) / observedDays);
-}
-
 function trendWarnings(windows: QueueTrendWindow[]): string[] {
   const warnings: string[] = [];
   for (const window of windows.filter((entry) => entry.status === "ready")) {

test/unit/queue-trends.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, it } from "vitest";
 import { getRepoQueueTrendSnapshot, persistRepoGithubTotalsSnapshot, persistSignalSnapshot, upsertPullRequestFromGitHub, upsertRepositoryFromGitHub } from "../../src/db/repositories";
 import { generateSignalSnapshots } from "../../src/queue/processors";
-import { buildQueueTrendReport, buildUnavailableQueueTrendReport, computeReviewVelocityPerDay, type QueueTrendReport } from "../../src/services/queue-trends";
+import { buildQueueTrendReport, buildUnavailableQueueTrendReport, type QueueTrendReport } from "../../src/services/queue-trends";
 import type { RepoGithubTotalsSnapshotRecord } from "../../src/types";
 import { createTestEnv } from "../helpers/d1";
 
@@ -70,9 +70,7 @@ describe("queue trend windows", () => {
     for (const window of report.windows.filter((entry) => entry.status === "ready")) {
       expect(window.reviewVelocityPerDay).not.toBe(Infinity);
       expect(window.summary).not.toContain("Infinity");
-      if (window.reviewVelocityPerDay !== null) {
-        expect(Number.isFinite(window.reviewVelocityPerDay)).toBe(true);
-      }
+      expect(Number.isFinite(window.reviewVelocityPerDay)).toBe(true);
     }
     expect(report.windows[0]).toMatchObject({
       windowDays: 7,
@@ -83,11 +81,6 @@ describe("queue trend windows", () => {
     });
   });
 
-  it("returns null review velocity when observedDays is zero", () => {
-    expect(computeReviewVelocityPerDay(7, 3, 0)).toBeNull();
-    expect(computeReviewVelocityPerDay(7, 3, 7)).toBe(1.43);
-  });
-
   it("returns clear unavailable windows when history is missing", () => {
     const report = buildQueueTrendReport({ repoFullName: "owner/repo", totalsSnapshots: [totals(0, { openIssues: 1, openPrs: 1, merged: 0, closed: 0 })] });
     expect(report).toMatchObject({