Skip to content

Commit 069a45a

Browse files
ProskyneteProskynete
authored
Linter rules (#159)
## Detalle: - Se agregaron nuevas reglas de linter, esto hizo que se tuviera que modificar los archivos - Me limité solo a la corrección de las nuevas reglas de linter - Cambié el nombre de `DefaultPagelayout` a `DefaultPageLayout` (es porque estaba mal escrito) - Al agregar el plugin `eslint-plugin-import` al archivo `.eslintrc.json` empezaron a aparecer warnings y errores (los cuales también fueron corregidos) como: - `Error: JwtPayload not found in 'jwt-decode'` - `Warning: Using exported name 'gql' as identifier for default export.` - Queda solo un `warning`, que es sobre una dependencia con un `useMemo`, pero no sé si se utiliza o no. ### Las reglas son: - `import/order` - Con esto se ordenarán los `imports`: - Alfabéticamente ascendente - Agrupados por tipo y con salto de líneas entre grupos - `import/no-named-as-default` - Habían `warnings` que salían una que se incorporó la regla `import/order`. - `no-console` - No es buena práctica mostrar `console.logs` - Si estamos permitiendo `warns`, `errors` e `info` ## Evidencia Warnings por la incroportación de la regla del import ![Screenshot 2022-12-19 at 16 58 13](https://user-images.githubusercontent.com/11874455/208528014-50042040-d492-4e06-b70e-06a305268e42.png) ![Screenshot 2022-12-19 at 18 32 14](https://user-images.githubusercontent.com/11874455/208528134-2f8de828-6702-46b2-9aae-bdaeb339bf4e.png)
1 parent 5430fa8 commit 069a45a

File tree

108 files changed

+359
-259
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

108 files changed

+359
-259
lines changed

‎.eslintrc.js

+10
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ module.exports = {
1010
"next/core-web-vitals",
1111
"plugin:react/recommended",
1212
"standard-with-typescript",
13+
"plugin:import/recommended",
1314
"prettier",
1415
],
1516
overrides: [],
@@ -27,5 +28,14 @@ module.exports = {
2728
"@typescript-eslint/no-non-null-assertion": ["off"],
2829
"@typescript-eslint/no-non-null-asserted-optional-chain": ["off"],
2930
"@next/next/no-img-element": ["off"],
31+
"no-console": ["error", { allow: ["warn", "error", "info"] }],
32+
"import/no-named-as-default": 0,
33+
"import/order": [
34+
"error",
35+
{
36+
"newlines-between": "always-and-inside-groups",
37+
alphabetize: { order: "asc" },
38+
},
39+
],
3040
},
3141
};

‎pages/404.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import styled from "@emotion/styled";
2+
23
import { ErrorComponent } from "../src/Components/ErrorComponent";
3-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
4+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
45

56
const Container = styled.section`
67
display: flex;
@@ -18,4 +19,4 @@ export default function Page404() {
1819
);
1920
}
2021

21-
Page404.getLayout = DefaultPagelayout;
22+
Page404.getLayout = DefaultPageLayout;

‎pages/500.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import styled from "@emotion/styled";
2+
23
import { ErrorComponent } from "../src/Components/ErrorComponent";
3-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
4+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
45

56
const Container = styled.section`
67
display: flex;
@@ -18,4 +19,4 @@ export default function Page404() {
1819
);
1920
}
2021

21-
Page404.getLayout = DefaultPagelayout;
22+
Page404.getLayout = DefaultPageLayout;

‎pages/_app.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import {
2020
useState,
2121
} from "react";
2222
import { Provider } from "urql";
23+
2324
import { urlQlient } from "../src/graphql/urql";
2425
import { isAuthenticatedAtom } from "../src/helpers/auth";
2526
import { GlobalStyles } from "../styles/globalStyles";

‎pages/auth/github/callback.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { useSetAtom } from "jotai";
44
import type { NextPage } from "next";
55
import { useRouter } from "next/router";
66
import { useEffect, useState } from "react";
7+
78
import { ErrorComponent } from "../../../src/Components/ErrorComponent";
89
import { finishGithubLogin } from "../../../src/helpers/API";
910
import { accessTokenAtom } from "../../../src/helpers/auth";

‎pages/auth/google/callback.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { useSetAtom } from "jotai";
44
import type { NextPage } from "next";
55
import { useRouter } from "next/router";
66
import { useEffect, useState } from "react";
7+
78
import { ErrorComponent } from "../../../src/Components/ErrorComponent";
89
import { finishGoogleLogin } from "../../../src/helpers/API";
910
import { accessTokenAtom } from "../../../src/helpers/auth";

‎pages/auth/logout.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@ import { useSetAtom } from "jotai";
33
import type { NextPage } from "next";
44
import { useRouter } from "next/router";
55
import { useEffect } from "react";
6+
67
import { accessTokenAtom } from "../../src/helpers/auth";
78

89
const Container = styled.section`

‎pages/cfp.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import dynamic from "next/dynamic";
22
import { Suspense } from "react";
3+
4+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
35
import Seo from "../src/Components/Seo";
46
import {
57
CfpQueryDocument,
@@ -8,7 +10,6 @@ import {
810
} from "../src/graphql/cfp.generated";
911
import { urlQlient } from "../src/graphql/urql";
1012
import { ParseQuery } from "../src/helpers/types";
11-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
1213

1314
const BannerCFP = dynamic(
1415
async () => await import("../src/Components/Banner/CFP")
@@ -55,4 +56,4 @@ export async function getStaticProps() {
5556
};
5657
}
5758

58-
OnSitePage.getLayout = DefaultPagelayout;
59+
OnSitePage.getLayout = DefaultPageLayout;

‎pages/faq.tsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
11
import styled from "@emotion/styled";
2-
import { H1 } from "../src/Components/core/Typography";
2+
33
import { CustomMarkdown } from "../src/Components/CustomMarkdown";
4-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
4+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
55
import Seo from "../src/Components/Seo";
6+
import { H1 } from "../src/Components/core/Typography";
67
import {
78
FaqDocument,
89
FaqQueryVariables,
@@ -88,4 +89,4 @@ export async function getStaticProps() {
8889
};
8990
}
9091

91-
FAQ.getLayout = DefaultPagelayout;
92+
FAQ.getLayout = DefaultPageLayout;

‎pages/index.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
import styled from "@emotion/styled";
22
import type { NextPage } from "next";
33
import { lazy, Suspense } from "react";
4+
5+
import Seo from "../src/Components/Seo";
46
import EventSchema from "../src/Components/schema/event";
57
import Hero from "../src/Components/sections/Hero";
6-
import Seo from "../src/Components/Seo";
78
import {
89
HomeQueryDocument,
910
HomeQueryQuery,

‎pages/laprevia.tsx

+5-6
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
import styled from "@emotion/styled";
2+
import type { NextPage } from "next";
23
import dynamic from "next/dynamic";
34
import { lazy, Suspense } from "react";
4-
import type { NextPage } from "next";
5-
6-
import { urlQlient } from "../src/graphql/urql";
7-
import { ParseQuery } from "../src/helpers/types";
8-
import { ViewportSizes } from "../styles/theme";
95

6+
import { StyledWrapperSuspense } from "../src/Components/NavBar/components";
107
import {
118
LaPreviaDocument,
129
LaPreviaQuery,
1310
} from "../src/graphql/laprevia.generated";
14-
import { StyledWrapperSuspense } from "../src/Components/NavBar/components";
11+
import { urlQlient } from "../src/graphql/urql";
12+
import { ParseQuery } from "../src/helpers/types";
13+
import { ViewportSizes } from "../styles/theme";
1514

1615
const Particles = lazy(async () => await import("../src/Components/Particles"));
1716

‎pages/mytickets/[id].tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,11 @@ import { css, keyframes } from "@emotion/react";
22
import styled from "@emotion/styled";
33
import { useRouter } from "next/router";
44
import { useCallback, useState } from "react";
5+
56
import { FormPageContainer } from "../../src/Components/Form/components";
67

78
import {
8-
DefaultPagelayout,
9+
DefaultPageLayout,
910
InternalPageTitle,
1011
} from "../../src/Components/Layouts/DefaultPagelayout";
1112
import { UserPreferencesForm } from "../../src/Components/UserPreferencesForm";
@@ -74,6 +75,6 @@ const Settings = () => {
7475
);
7576
};
7677

77-
Settings.getLayout = DefaultPagelayout;
78+
Settings.getLayout = DefaultPageLayout;
7879

7980
export default Settings;

‎pages/mytickets/index.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
import styled from "@emotion/styled";
22
import { useQuery } from "@tanstack/react-query";
3-
import { PageContainer } from "../../src/Components/common/PageContainer";
43

54
import {
6-
DefaultPagelayout,
5+
DefaultPageLayout,
76
InternalPageTitle,
87
} from "../../src/Components/Layouts/DefaultPagelayout";
9-
import { FakeTicketContainer } from "../../src/Components/Ticket/components";
108
import { TicketsList } from "../../src/Components/Ticket/TicketsList";
9+
import { FakeTicketContainer } from "../../src/Components/Ticket/components";
10+
import { PageContainer } from "../../src/Components/common/PageContainer";
1111

1212
import { me, myTickets } from "../../src/helpers/API";
1313

@@ -42,7 +42,7 @@ const Settings = () => {
4242
);
4343
};
4444

45-
Settings.getLayout = DefaultPagelayout;
45+
Settings.getLayout = DefaultPageLayout;
4646

4747
export const config = {
4848
runtime: "experimental-edge",

‎pages/online.tsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
import { lazy, Suspense } from "react";
2+
3+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
4+
import Seo from "../src/Components/Seo";
25
import {
36
HowQueryDocument,
47
HowQueryQuery,
@@ -7,8 +10,6 @@ import {
710

811
import { urlQlient } from "../src/graphql/urql";
912
import { ParseQuery } from "../src/helpers/types";
10-
import Seo from "../src/Components/Seo";
11-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
1213

1314
const HowCard = lazy(async () => await import("../src/Components/Card/How"));
1415

@@ -54,4 +55,4 @@ export async function getStaticProps() {
5455
};
5556
}
5657

57-
OnlinePage.getLayout = DefaultPagelayout;
58+
OnlinePage.getLayout = DefaultPageLayout;

‎pages/onsite.tsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,14 @@
11
import { lazy, Suspense } from "react";
2+
3+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
4+
import Seo from "../src/Components/Seo";
25
import {
36
HowQueryDocument,
47
HowQueryQuery,
58
HowQueryQueryVariables,
69
} from "../src/graphql/how.generated";
710
import { urlQlient } from "../src/graphql/urql";
811
import { ParseQuery } from "../src/helpers/types";
9-
import Seo from "../src/Components/Seo";
10-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
1112

1213
const HowCard = lazy(async () => await import("../src/Components/Card/How"));
1314

@@ -61,4 +62,4 @@ export async function getStaticProps() {
6162
};
6263
}
6364

64-
OnSitePage.getLayout = DefaultPagelayout;
65+
OnSitePage.getLayout = DefaultPageLayout;

‎pages/p/ticket/[id].tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@ import { GetServerSidePropsContext } from "next";
33
import dynamic from "next/dynamic";
44
import Head from "next/head";
55
import { Suspense } from "react";
6+
7+
import { DefaultPageLayout } from "../../../src/Components/Layouts/DefaultPagelayout";
68
import { PublicTicket } from "../../../src/helpers/API/types";
7-
import { DefaultPagelayout } from "../../../src/Components/Layouts/DefaultPagelayout";
89

910
const Ticket = dynamic(
1011
async () => {
@@ -119,6 +120,5 @@ export const getServerSideProps = async ({
119120
return { props: { ticket, cleanedId: id } };
120121
};
121122

122-
TicketPage.getLayout = DefaultPagelayout;
123-
123+
TicketPage.getLayout = DefaultPageLayout;
124124
export default TicketPage;

‎pages/politicas_de_privacidad.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import styled from "@emotion/styled";
2+
23
import { CustomMarkdown } from "../src/Components/CustomMarkdown";
3-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
4+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
45
import {
56
PoliticasDePrivacidadPageDocument,
67
PoliticasDePrivacidadPageQuery,
@@ -78,4 +79,4 @@ export async function getStaticProps() {
7879
};
7980
}
8081

81-
PoliticasDePrivacidad.getLayout = DefaultPagelayout;
82+
PoliticasDePrivacidad.getLayout = DefaultPageLayout;

‎pages/settings.tsx

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ import { useQuery } from "@tanstack/react-query";
33
import Link from "next/link";
44
import { Anchor } from "react-feather";
55

6-
import { Alert } from "../src/Components/common/app";
76
import { FormPageContainer } from "../src/Components/Form/components";
8-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
7+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
98
import { UserInformationForm } from "../src/Components/UserInformationForm";
109
import { UserPreferencesForm } from "../src/Components/UserPreferencesForm";
10+
import { Alert } from "../src/Components/common/app";
1111

1212
import { me, updateMe } from "../src/helpers/API";
1313
import { jsconfTheme } from "../styles/theme";
@@ -66,6 +66,6 @@ const Settings = () => {
6666
);
6767
};
6868

69-
Settings.getLayout = DefaultPagelayout;
69+
Settings.getLayout = DefaultPageLayout;
7070

7171
export default Settings;

‎pages/sponsor.tsx

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
1-
import { lazy, Suspense } from "react";
21
import styled from "@emotion/styled";
2+
import { lazy, Suspense } from "react";
33

4+
import { DefaultPageLayout } from "../src/Components/Layouts/DefaultPagelayout";
5+
import Seo from "../src/Components/Seo";
46
import {
57
SponsorQueryDocument,
68
SponsorQueryQuery,
79
SponsorQueryQueryVariables,
810
} from "../src/graphql/sponsor.generated";
911
import { urlQlient } from "../src/graphql/urql";
10-
import Seo from "../src/Components/Seo";
1112
import { ParseQuery } from "../src/helpers/types";
1213
import { ViewportSizes } from "../styles/theme";
13-
import { DefaultPagelayout } from "../src/Components/Layouts/DefaultPagelayout";
1414

1515
const BannerSponsor = lazy(
1616
async () => await import("../src/Components/Banner/Sponsor")
@@ -88,4 +88,4 @@ export async function getStaticProps() {
8888
};
8989
}
9090

91-
OnSitePage.getLayout = DefaultPagelayout;
91+
OnSitePage.getLayout = DefaultPageLayout;

‎pages/tickets/error.tsx

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import styled from "@emotion/styled";
2+
23
import { ErrorComponent } from "../../src/Components/ErrorComponent";
3-
import { DefaultPagelayout } from "../../src/Components/Layouts/DefaultPagelayout";
4+
import { DefaultPageLayout } from "../../src/Components/Layouts/DefaultPagelayout";
45
import { TicketsQueryQuery } from "../../src/graphql/tickets.generated";
56
import { ParseQuery } from "../../src/helpers/types";
67
import { ViewportSizes } from "../../styles/theme";
@@ -42,4 +43,4 @@ export default function Tickets(props: PageProps) {
4243
);
4344
}
4445

45-
Tickets.getLayout = DefaultPagelayout;
46+
Tickets.getLayout = DefaultPageLayout;

‎pages/tickets/index.tsx

+4-3
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
import { useQuery } from "@tanstack/react-query";
22
import { useAtomValue, useSetAtom } from "jotai";
3+
34
import {
45
availableTicketsAtom,
56
ticketsAtom,
67
} from "../../src/Components/Cart/CartAtom";
78
import { CartContainer } from "../../src/Components/Cart/CartContainer";
8-
import { PageContainer } from "../../src/Components/common/PageContainer";
9-
import { DefaultPagelayout } from "../../src/Components/Layouts/DefaultPagelayout";
9+
import { DefaultPageLayout } from "../../src/Components/Layouts/DefaultPagelayout";
1010
import Seo from "../../src/Components/Seo";
1111
import NoTickets from "../../src/Components/TicketSection/NoTickets";
1212
import YesTicketsCreateAccount from "../../src/Components/TicketSection/YesTicketsCreateAccount";
13+
import { PageContainer } from "../../src/Components/common/PageContainer";
1314
import {
1415
TicketsQueryDocument,
1516
TicketsQueryQuery,
@@ -83,4 +84,4 @@ export async function getStaticProps() {
8384
};
8485
}
8586

86-
Tickets.getLayout = DefaultPagelayout;
87+
Tickets.getLayout = DefaultPageLayout;

0 commit comments

Comments
 (0)