-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
641-incorporate-feedback-from-the-second-audit #662
base: master
Are you sure you want to change the base?
Conversation
module WDYT? @WhatisRT @williamdemeo |
0707414
to
e4000d4
Compare
I think the simplest thing to do would be to leave the ordering as it is and in the first place where |
e4000d4
to
a6dbc56
Compare
Here are some answers to the open items. If you have further questions let me know!
I assume that's still in the prose, but we aren't actually doing this anymore because there was a memory attack if it was allowed. You could spam votes on irrelevant things, and it would fill up the state faster & cheaper than we want to allow. We now have things like
It's a Shelley-era thing that hasn't meaningfully changed since then, and the reviewed spec just shows changes. So it makes sense to be hidden here but it should be visible in the full spec.
I'm not sure where an issue would arise, this is just giving an extra annotation that is being checked for correctness. Previously the ledger would compute deposits for you, so when making a transaction with certificates it was harder to know if it balances properly because you'd have to mimic the calculations the ledger does. Now you just add up all the numbers in there, and if the transaction is valid this sum is guaranteed to be what you pay/receive.
This is explained by
No, it didn't change.
I think this question is because in the first audit it was. However, that was just a shortcut I took early in writing the Conway spec and was completely incorrect. The mechanism that moves and distributes transaction fees is
Yes.
Yes, bootstrapping was done with an interim CC. I'm not sure how exactly the members were selected, but it's not really in scope of the spec anyway. We can just say that it's required to supply a sensible initial value. |
Addresses #641
TODO (partial):
security group's threshold
parameter fromQ5e
toQ5
(Sec. 3, pp. 8-9)UpdateT
and how its used to check wellformedness (Sec. 3, pp. 8)actionWellFormed
for the case ofTreasuryWdrl
, and address the question: should the parameterx : RwdAddr ⇀ Coin
be also wellformed? (Sec. 4, pp. 11-12) (yes, solved by Moved action specific predicates to actionWellFormed and fix a conformance failure #673)Add description ofrefInputs
(Sec. 5, pp 15)curTreasury
andtxdonation
(Sec. 5, pp. 15)txid
(Sec. 5, pp. 15)Deposits
is used in Sec. 6 (Figs. 12 and 13) but introduced in Sec. 8, Fig. 23Suggestion to put back definition ofcwitness
(Sec. 8)Enact-NewComm
toEnact-UpdComm
(Sec. 10, pp. 31)threshold x
is meant as a fraction to the total stake of all votes, and how is the total stake counted for the purpose of counting if an action passes. (Sec. 11.1, pp. 39)ShouldNewEpochState
be part of Conway? if so add it to Fig. 41. (Sec. 12, pp. 46)Add explanation whyfees
is not used when computingtreasury
in Fig. 43. (Sec. 12, pp. 48)Checklist
CHANGELOG.md