Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate the incoming TLS connection against the incoming DAT #439

Closed
HeinrichPet opened this issue Feb 22, 2022 · 6 comments
Closed

Validate the incoming TLS connection against the incoming DAT #439

HeinrichPet opened this issue Feb 22, 2022 · 6 comments

Comments

@HeinrichPet
Copy link

Currently, the Messaging Services only validates whether the DAT is correct and valid. However, the identity of the sender is not validated.

To do this, the transportCertsSha256 from the DAT must be matched with the fingerprint of the TLS certificate.
Therefore the IDS-Messaging Services (and also all other IDS implementations) must dynamically specify their TLS certifacte fingerprint in a DAT request so that the DAT is issued correctly. The DAT is returned only if the identity of the sender has been validated by the DAPS. Therefore, by matching the DAT with the transport certificate fingerprint, we can ensure, that the identity is checked by the DAPS.

Additionally, the hostname specified under referring Connector in the DAT should match the hostname of the TLS connection. This should also be checked.

@tmberthold
Copy link
Contributor

tmberthold commented Feb 22, 2022

must dynamically specify their TLS certifacte fingerprint in a DAT request
Do we already have a claim or other option for this in the DAT request? If not, it would have to be added.

Would have to be specified here first (can't identify a matching claim): https://github.com/International-Data-Spaces-Association/IDS-G/tree/main/Components/IdentityProvider/DAPS#request-token-that-is-handed-in-at-daps-side

@tmberthold
Copy link
Contributor

I think it's an ongoing discussion?!
Fraunhofer-AISEC/omejdn-server#38

@tmberthold
Copy link
Contributor

tmberthold commented May 18, 2022

Waiting for a reference implementation in EDC as this is on the schedule there for current milestone planning. Will then adapt that here when the solution is available. (Issue 1152 in EDC)

@bellebaum
Copy link

For reference, here is the current proposal for specifying the claims as a request parameter (private repo):
https://github.com/International-Data-Spaces-Association/IDS-G-pre/pull/84

@tmberthold
Copy link
Contributor

tmberthold commented May 18, 2022

Here's the link to the EDC issue, which is part of the Milestone 4 for the end of the month:
"check hostname of incoming request"
eclipse-edc/Connector#1152

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants