-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo in scripts/copy-full.sh & copy-all.sh #1961
Comments
It might be helpful in debugging loadup issues to add a parameter —help to the medley script that forces a break in ENDLOADUP, before the makesys and logout.
… On Jan 7, 2025, at 4:03 PM, Matt Heffron ***@***.***> wrote:
Assuming that the intent is to copy the RDSYS and RDSYS.LCOM to the main library folder, the scripts actually copy both to the scripts folder with the name library given to each (and version numbered).
/bin/sh "${LOADUP_SCRIPTDIR}/cpv" "${LOADUP_WORKDIR}"/RDSYS library
| sed -e "s#${MEDLEYDIR}/##g"
/bin/sh "${LOADUP_SCRIPTDIR}/cpv" "${LOADUP_WORKDIR}"/RDSYS.LCOM library
| sed -e "s#${MEDLEYDIR}/##g"
It seems it is assuming that the current connected directory is the MEDLEYDIR. It seems prudent to make the destination path more explicit. Like (?):
/bin/sh "${LOADUP_SCRIPTDIR}/cpv" "${LOADUP_WORKDIR}"/RDSYS "${MEDLEYDIR}"/library
| sed -e "s#${MEDLEYDIR}/##g"
/bin/sh "${LOADUP_SCRIPTDIR}/cpv" "${LOADUP_WORKDIR}"/RDSYS.LCOM "${MEDLEYDIR}"/library
| sed -e "s#${MEDLEYDIR}/##g"
—
Reply to this email directly, view it on GitHub <#1961>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQSTUJOT6JU524L5PUHCPIL2JRTNFAVCNFSM6AAAAABUYYCSSSVHI2DSMVQWIX3LMV43ASLTON2WKOZSG43TGOJWGIZTCNA>.
You are receiving this because you are subscribed to this thread.
|
@MattHeffron I caught this bug while working on what is now PR#1958. It is fixed in the slightly revamped copyall.sh included in that PR. Probably not worth it to create a separate PR just for this issue alone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Assuming that the intent is to copy the
RDSYS
andRDSYS.LCOM
to the mainlibrary
folder, the scripts actually copy both to thescripts
folder with the namelibrary
given to each (and version numbered).It seems it is assuming that the current connected directory is the
MEDLEYDIR
. It seems prudent to make the destination path more explicit. Like (?):The text was updated successfully, but these errors were encountered: