Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in scripts/copy-full.sh & copy-all.sh #1961

Open
MattHeffron opened this issue Jan 8, 2025 · 2 comments · May be fixed by #1958
Open

typo in scripts/copy-full.sh & copy-all.sh #1961

MattHeffron opened this issue Jan 8, 2025 · 2 comments · May be fixed by #1958

Comments

@MattHeffron
Copy link
Contributor

Assuming that the intent is to copy the RDSYS and RDSYS.LCOM to the main library folder, the scripts actually copy both to the scripts folder with the name library given to each (and version numbered).

/bin/sh "${LOADUP_SCRIPTDIR}/cpv" "${LOADUP_WORKDIR}"/RDSYS library
| sed -e "s#${MEDLEYDIR}/##g"
/bin/sh "${LOADUP_SCRIPTDIR}/cpv" "${LOADUP_WORKDIR}"/RDSYS.LCOM library
| sed -e "s#${MEDLEYDIR}/##g"

It seems it is assuming that the current connected directory is the MEDLEYDIR. It seems prudent to make the destination path more explicit. Like (?):

/bin/sh "${LOADUP_SCRIPTDIR}/cpv" "${LOADUP_WORKDIR}"/RDSYS "${MEDLEYDIR}"/library
| sed -e "s#${MEDLEYDIR}/##g"
/bin/sh "${LOADUP_SCRIPTDIR}/cpv" "${LOADUP_WORKDIR}"/RDSYS.LCOM "${MEDLEYDIR}"/library
| sed -e "s#${MEDLEYDIR}/##g"

@rmkaplan
Copy link
Contributor

rmkaplan commented Jan 8, 2025 via email

@fghalasz
Copy link
Member

fghalasz commented Jan 9, 2025

@MattHeffron I caught this bug while working on what is now PR#1958. It is fixed in the slightly revamped copyall.sh included in that PR. Probably not worth it to create a separate PR just for this issue alone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants