Format implementation functions set a known variable *BYTECOUNTER* (#402)

* Format implementation functions set a known variable *BYTECOUNTER*

The generic functions deal with updating the application variable.
\INCHAR eliminated in favor of \INCCODE.EOLC to make clear what it does.
OPENSTRINGSTREAM streams have their own format, and the string is always fattened.
READBITMAP doesn't mix character and byte reading

* AOFD: Don't execute \STRINGSTREAM.INIT

This creates a file device that is not used anywhere.  The function OPENSTRINGSTREAM provides the functionality that this file device suggests that it would provide, but that functionality seems suspect at best.  The function is left in the system for now, probably should be deleted at some point in the future so we don't try to maintain it if we trip over it.

* TTYIN:  Fix an ancient coding error

but still doesn't solve the  (DIRECTORY ?=  problem #402

* LLREAD, FILEIO, XCCS:  Improve charcode backing, copychars

Added \BACKCCODE.EOLC that backs up over EOL encoding bytes, simplifies \RSTRING2.
\XCCSBACKCCODE returns T/NIL according to whether it succeeded.
\XCCSOUTCHAR uses IPLUS16 for CHARPOSITION
COPYCHARS makes no assumptions about EOL encoding
But still no solution for #402

* LLREAD, TTYIN.LCOM    fix #402

The bug showed up in TTYIN, but it was actually a bad edit in the generic backccode.

TTYIN.LCOM is just a recompile--that had never been done with various new declarations.

Author: rmkaplan

library/UNICODE

@@ -1,11 +1,11 @@
-(DEFINE-FILE-INFO READTABLE "INTERLISP" PACKAGE "INTERLISP")
-
(FILECREATED "13-Jun-2021 11:35:32" {DSK}<Users>kaplan>Local>medley3.5>git-medley>sources>AOFD.;2
 35745  
+(DEFINE-FILE-INFO PACKAGE "INTERLISP" READTABLE "INTERLISP" BASE 10 FORMAT XCCS)
+
(FILECREATED " 9-Aug-2021 23:30:19" {DSK}<Users>kaplan>Local>medley3.5>git-medley>sources>AOFD.;5
 38301  
 
-      changes to%:  (FNS CLOSEF INPUT OUTPUT RANDACCESSP \MAKEBASEBYTESTREAM \BASEBYTES.PEEKBIN 
-                         \SEARCHOPENFILES)
+      changes to%:  (VARS AOFDCOMS)
+                    (FNS \STRINGSTREAM.INIT)
 
-      previous date%: "10-May-2021 15:44:43" 
-{DSK}<Users>kaplan>Local>medley3.5>git-medley>sources>AOFD.;1)
+      previous date%: " 8-Aug-2021 00:11:00" 
+{DSK}<Users>kaplan>Local>medley3.5>git-medley>sources>AOFD.;4)
 
 
 (* ; "
@@ -36,12 +36,15 @@ Copyright (c) 1981-1987, 1990, 2021 by Venue & Xerox Corporation.
                    \BASEBYTES.PEEKBIN \BASEBYTES.TRUNCATEFN \BASEBYTES.OPENFN \BASEBYTES.BLOCKIO)
               (GLOBALVARS \BASEBYTESDEVICE)
               (DECLARE%: DONTEVAL@LOAD (P (\BASEBYTES.IO.INIT)))
-              (FNS OPENSTRINGSTREAM))
-        [COMS 
-              (* ;; "STREAM interface for old-style strings")

+              (FNS OPENSTRINGSTREAM MAKE-STRING-FORMAT)
+              (P (MAKE-STRING-FORMAT)))
+        (COMS 
+              (* ;; "STREAM interface for old-style strings.  However (RMK), it appears never to be used, and even commonlisp string-streams are created using the Interlisp OPENSTRINGSTREAM above.  For now, keep the function, but don't execute it")

 
               (FNS \STRINGSTREAM.INIT)
-              (DECLARE%: DONTEVAL@LOAD DOCOPY (P (\STRINGSTREAM.INIT]
+              
+              (* ;; "(DECLARE%%: DONTEVAL@LOAD DOCOPY (P (\STRINGSTREAM.INIT)))")

+)
         (COMS (FNS GETSTREAM \ADDOFD \CLEAROFD \DELETEOFD \GETSTREAM \SEARCHOPENFILES)
               (DECLARE%: DONTCOPY (EXPORT (MACROS \INSTREAMARG \OUTSTREAMARG \STREAMARG)))
               (MACROS GETOFD \GETOFD))
@@ -532,50 +535,98 @@ Copyright (c) 1981-1987, 1990, 2021 by Venue & Xerox Corporation.
 (DEFINEQ
 
 (OPENSTRINGSTREAM

-  [LAMBDA (STR ACCESS)                                       (* rmk%: "28-Mar-85 08:40")
-          
-          (* ;; "Does not register the stream on \OPENFILES, nor does it search \OPENFILES for a previously opened stream.  Thus, this implementation does not side-effect the string as the 10 does.  However, the temporary coercion of strings to open streams in \GETSTREAM does simulate the side-effecting.  Note that a string stream is unnamed.")
-
-    (PROG (STREAM FATP)
-          (OR (STRINGP STR)
-              (\ILLEGAL.ARG STR))
-          (SETQ FATP (ffetch
 (STRINGP FATSTRINGP) of
 STR))
-          [SETQ STREAM (\MAKEBASEBYTESTREAM
 (OR (ffetch
 (STRINGP BASE) of
 STR)
-                                                T)
-                              (COND
-                                 (FATP (UNFOLD (ffetch
 (STRINGP OFFST) of
 STR)
-                                              BYTESPERWORD))
-                                 (T (ffetch
 (STRINGP OFFST) of
 STR)))
-                              (COND
-                                 (FATP (UNFOLD (ffetch
 (STRINGP LENGTH) of
 STR)
-                                              BYTESPERWORD))
-                                 (T (ffetch
 (STRINGP LENGTH) of
 STR)))
-                              (SELECTQ ACCESS
-                                  ((INPUT OUTPUT BOTH) 
-                                       ACCESS)
-                                  (NIL 'INPUT)
-                                  (\ILLEGAL.ARG ACCESS]
-          (PROGN                                             (* ; 
-                                      "Minor differences between a basebytestream and a stringstream")
-                 (if
 FATP
-                     then
 (freplace
 (STREAM CHARSET) of
 STREAM with
 \NORUNCODE))
-                 (freplace
 USERCLOSEABLE of
 STREAM with
 T)
-                 (freplace
 USERVISIBLE of
 STREAM with
 T)
-                 (SELECTQ (SYSTEMTYPE)
-                     (VAX (freplace
 F2 of
 STREAM with
 0)
-                          (freplace
 STRMBINFN of
 STREAM with
 (FUNCTION \STRINGBIN)))
-                     NIL))
-          (RETURN STREAM])
+  [LAMBDA (STR ACCESS)
                                  (* ; "Edited  8-Aug-2021 00:02 by rmk:")


+                                                             (* rmk%: "28-Mar-85 08:40")

+
+    (* ;; "We fatten thin strings at the start so that the byte-level functions (bin, bout, getfileptr, setfrileptr) give the same (2-bytes per character) picture of the byte sequence even if we started out thin.")

+
+    (* ;; "Does not register the stream on \OPENFILES, nor does it search \OPENFILES for a previously opened stream. ")

+
+    (SELECTQ ACCESS
+        ((INPUT OUTPUT BOTH))
+        (NIL (SETQ ACCESS 'INPUT))
+        (\ILLEGAL.ARG ACCESS))
+    (CL:UNLESS (STRINGP STR)
+           (\ILLEGAL.ARG STR))
+    (LET (STREAM)
+         (IF
 (AND (EQ ACCESS 'INPUT)
+                      (NOT (ffetch
 (STRINGP FATSTRINGP) of
 STR)))
+             THEN
 (\FATTENSTRING STR)
+           ELSE
 (\SMASHABLESTRING STR T))
+
+         (* ;; "String storage is now fat")

+
+         (SETQ STREAM (\MAKEBASEBYTESTREAM
 (OR (ffetch
 (STRINGP BASE) of
 STR)
+                                                   T)
+                             (UNFOLD (ffetch
 (STRINGP OFFST) of
 STR)
+                                    BYTESPERWORD)
+                             (UNFOLD (ffetch
 (STRINGP LENGTH) of
 STR)
+                                    BYTESPERWORD)
+                             ACCESS))
+
+         (* ;; "Differences between a basebytestream and a stringstream")

+
+         (\EXTERNALFORMAT STREAM :STRING)
+         (freplace
 USERCLOSEABLE of
 STREAM with
 T)
+         (freplace
 USERVISIBLE of
 STREAM with
 T)
+         STREAM])
+
+(MAKE-STRING-FORMAT

+  [LAMBDA NIL
                                           (* ; "Edited  8-Aug-2021 00:10 by rmk:")

+
+    (* ;; "We are looking at an in-core string, we know that EOL is CR, that the characters have the internal (XCCS) encoding, and that the string is fat. ")

+
+    (MAKE-EXTERNALFORMAT :STRING [FUNCTION (LAMBDA (STRM COUNTP)
+                                             (DECLARE
 (USEDFREE *BYTECOUNTER*))
+                                             (CL:WHEN COUNTP (SETQ *BYTECOUNTER* 2))
+                                             (\WIN STRM]
+           [FUNCTION (LAMBDA (STRM NOERROR)
+                       (CL:WHEN (\PEEKBIN STRM NOERROR)
+
+                           (* ;; "This guards against the EOF error")

+
+                           (PROG1 (LOGOR (LLSH (\BIN STRM)
+                                               8)
+                                         (\PEEKBIN STRM NOERROR))
+                                  (\BACKFILEPTR STRM)))]
+           [FUNCTION (LAMBDA (STRM COUNTP)
+                       (DECLARE
 (USEDFREE *BYTECOUNTER*))
+                       (CL:WHEN (\BACKFILEPTR STRM)
+                           (IF
 (\BACKFILEPTR STRM)
+                               THEN
 (CL:WHEN COUNTP (SETQ *BYTECOUNTER* 2))
+                                     T
+                             ELSEIF
 COUNTP
+                               THEN
 (SETQ *BYTECOUNTER* 1)))]
+           [FUNCTION (LAMBDA (STRM CODE)
+                       (\WOUT STRM CODE)
+                       CODE]
+           NIL
+           'CR])
 )
 
+(MAKE-STRING-FORMAT
)
+
 
 
-(* ;; "STREAM interface for old-style strings")

+(* ;; 
+"STREAM interface for old-style strings.  However (RMK), it appears never to be used, and even commonlisp string-streams are created using the Interlisp OPENSTRINGSTREAM above.  For now, keep the function, but don't execute it"
+)

 
 (DEFINEQ
 
 (\STRINGSTREAM.INIT

-  [LAMBDA NIL                                                (* bvm%: "14-Feb-85 00:25")
+  [LAMBDA NIL
                                           (* ; "Edited  9-Aug-2021 23:30 by rmk:")

+
+    (* ;; "RMK: This is described as creating a file device for %"old style%" strings.  But the variable that it sets is never referenced.  The common lisp functions that treat strings as streams all seem to go through OPENSTRINGSTREAM, which now has a proper external format.")

+
+    (* ;; "Moreover, it appears that the BIN function defined here, in terms of GNC, would have had the effect of updating the string pointer of the string as visible using ordinary string functions.  ")

+
+    (* ;; "Finally, this appears to be read only.  No BOUT is provided.")

+
+    (* ;; "")

+
+    (* ;; " In sum:  this is a candidate for removal.")

+
     (SETQ \STRINGSTREAM.FDEV (create
 FDEV
                                     DEVICENAME _ 'STRING
                                     CLOSEFILE _ (FUNCTION NILL)
@@ -588,7 +639,7 @@ Copyright (c) 1981-1987, 1990, 2021 by Venue & Xerox Corporation.
                                     HOSTNAMEP _ (FUNCTION NILL)
                                     OPENFILE _ (FUNCTION NILL)
                                     READPAGES _ (FUNCTION \ILLEGAL.DEVICEOP)
-                                    REOPENFILE _ [FUNCTION (LAMBDA (FILE ACCESS RECOG OTHERINFO FDEV 
+                                    REOPENFILE _ [FUNCTION (LAMBDA (FILE ACCESS RECOG OTHERINFO FDEV
                                                                          STREAM)
                                                              STREAM]
                                     SETFILEINFO _ (FUNCTION NILL)
@@ -597,13 +648,16 @@ Copyright (c) 1981-1987, 1990, 2021 by Venue & Xerox Corporation.
                                     BIN _ [FUNCTION (LAMBDA (STREAM)
                                                       (replace
 F2 of
 STREAM
                                                          with
 (COND
-                                                                 ((fetch
 F1 of
 STREAM)
-                                                                  (PROG1 (fetch
 F1 of
 STREAM)
-                                                                         (replace
 F1 of
 STREAM
-                                                                            with
 NIL)))
-                                                                 ((GNCCODE (fetch
 FULLFILENAME
-                                                                              of
 STREAM)))
-                                                                 (T (\EOF.ACTION STREAM]
+                                                                     ((fetch
 F1 of
 STREAM)
+                                                                      (PROG1 (fetch
 F1
+                                                                                of
 STREAM)
+                                                                             (replace
 F1
+                                                                                of
 STREAM
+                                                                                with
 NIL)))
+                                                                     ((GNCCODE (fetch
 
+                                                                                      FULLFILENAME
+                                                                                  of
 STREAM)))
+                                                                     (T (\EOF.ACTION STREAM]
                                     PEEKBIN _ [FUNCTION (LAMBDA (STREAM NOERRORFLG)
                                                           (OR (fetch
 F1 of
 STREAM)
                                                               (CHCON1 (fetch
 FULLFILENAME
@@ -614,17 +668,19 @@ Copyright (c) 1981-1987, 1990, 2021 by Venue & Xerox Corporation.
                                                         (NOT (EOFP STREAM]
                                     BACKFILEPTR _ [FUNCTION (LAMBDA (STREAM)
                                                               (replace
 F1 of
 STREAM
-                                                                 with
 (fetch
 F2 of
 STREAM]
+                                                                 with
 (fetch
 F2 of
 STREAM
+                                                                                 ]
                                     EOFP _ (FUNCTION (LAMBDA (STREAM)
                                                        (AND (NOT (fetch
 F1 of
 STREAM))
                                                             (EQ (NCHARS (fetch
 FULLFILENAME
                                                                            of
 STREAM))
                                                                 0])
 )
-(DECLARE%: DONTEVAL@LOAD DOCOPY 
 
-(\STRINGSTREAM.INIT
)
-)
+
+
+(* ;; "(DECLARE%%: DONTEVAL@LOAD DOCOPY (P (\STRINGSTREAM.INIT)))")

+
 (DEFINEQ
 
 (GETSTREAM

@@ -748,16 +804,16 @@ Copyright (c) 1981-1987, 1990, 2021 by Venue & Xerox Corporation.
 )
 (PUTPROPS AOFD COPYRIGHT ("Venue & Xerox Corporation" 1981 1982 1983 1984 1985 1986 1987 1990 2021))
 (DECLARE%: DONTCOPY
-  (FILEMAP (NIL (2373 3480 (\ADD-OPEN-STREAM 2383 . 2660) (\GENERIC-UNREGISTER-STREAM 2662 . 3478)) (
-3521 10778 (CLOSEALL 3531 . 4236) (CLOSEF 4238 . 5434) (EOFCLOSEF 5436 . 5732) (INPUT 5734 . 6506) (
-OPENP 6508 . 6907) (OUTPUT 6909 . 7683) (POSITION 7685 . 8497) (RANDACCESSP 8499 . 8974) (\IOMODEP 
-8976 . 9613) (WHENCLOSE 9615 . 10776)) (10779 10901 (STREAMADDPROP 10789 . 10899)) (12065 24946 (
-\BASEBYTES.IO.INIT 12075 . 15271) (\MAKEBASEBYTESTREAM 15273 . 18585) (\MBS.OUTCHARFN 18587 . 18975) (
-\BASEBYTES.NAME.FROM.STREAM 18977 . 19440) (\BASEBYTES.BOUT 19442 . 20159) (\BASEBYTES.SETFILEPTR 
-20161 . 20782) (\BASEBYTES.READP 20784 . 21420) (\BASEBYTES.BIN 21422 . 21953) (\BASEBYTES.PEEKBIN 
-21955 . 22786) (\BASEBYTES.TRUNCATEFN 22788 . 23292) (\BASEBYTES.OPENFN 23294 . 23784) (
-\BASEBYTES.BLOCKIO 23786 . 24944)) (25069 27319 (OPENSTRINGSTREAM 25079 . 27317)) (27376 31012 (
-\STRINGSTREAM.INIT 27386 . 31010)) (31074 34646 (GETSTREAM 31084 . 31307) (\ADDOFD 31309 . 31596) (
-\CLEAROFD 31598 . 31879) (\DELETEOFD 31881 . 32032) (\GETSTREAM 32034 . 34198) (\SEARCHOPENFILES 34200
- . 34644)))))
+  (FILEMAP (NIL (2615 3722 (\ADD-OPEN-STREAM 2625 . 2902) (\GENERIC-UNREGISTER-STREAM 2904 . 3720)) (
+3763 11020 (CLOSEALL 3773 . 4478) (CLOSEF 4480 . 5676) (EOFCLOSEF 5678 . 5974) (INPUT 5976 . 6748) (
+OPENP 6750 . 7149) (OUTPUT 7151 . 7925) (POSITION 7927 . 8739) (RANDACCESSP 8741 . 9216) (\IOMODEP 
+9218 . 9855) (WHENCLOSE 9857 . 11018)) (11021 11143 (STREAMADDPROP 11031 . 11141)) (12307 25188 (
+\BASEBYTES.IO.INIT 12317 . 15513) (\MAKEBASEBYTESTREAM 15515 . 18827) (\MBS.OUTCHARFN 18829 . 19217) (
+\BASEBYTES.NAME.FROM.STREAM 19219 . 19682) (\BASEBYTES.BOUT 19684 . 20401) (\BASEBYTES.SETFILEPTR 
+20403 . 21024) (\BASEBYTES.READP 21026 . 21662) (\BASEBYTES.BIN 21664 . 22195) (\BASEBYTES.PEEKBIN 
+22197 . 23028) (\BASEBYTES.TRUNCATEFN 23030 . 23534) (\BASEBYTES.OPENFN 23536 . 24026) (
+\BASEBYTES.BLOCKIO 24028 . 25186)) (25311 28620 (OPENSTRINGSTREAM 25321 . 27038) (MAKE-STRING-FORMAT 
+27040 . 28618)) (28892 33553 (\STRINGSTREAM.INIT 28902 . 33551)) (33630 37202 (GETSTREAM 33640 . 33863
+) (\ADDOFD 33865 . 34152) (\CLEAROFD 34154 . 34435) (\DELETEOFD 34437 . 34588) (\GETSTREAM 34590 . 
+36754) (\SEARCHOPENFILES 36756 . 37200)))))
 STOP