Merge pull request #171 from Intelligent-Advisor-Sem-4/main

Refactor risk score update process to improve API rate limit handling…

Author: dpiyumal2319

API/triggers.py

@@ -1,4 +1,4 @@
-from fastapi import APIRouter, Depends
+from fastapi import APIRouter, Depends, BackgroundTasks
 from sqlalchemy.orm import Session
 from db.dbConnect import get_db
 from services.asset_management import update_all_stock_risk_scores
@@ -10,7 +10,7 @@
 
 
 @router.post("/update-risk-scores", status_code=200)
-def trigger_risk_score_updates(db: Session = Depends(get_db)):
+def trigger_risk_score_updates(background_tasks: BackgroundTasks, db: Session = Depends(get_db)):
     """Trigger risk score updates for all stocks in the database."""
-    update_all_stock_risk_scores(db)
-    return {"message": "Risk score update initiated for all stocks"}
+    background_tasks.add_task(update_all_stock_risk_scores, db)
+    return {"message": "Risk score update initiated in the background"}

services/asset_management.py

@@ -1,11 +1,11 @@
 from datetime import datetime
+import time
 
 import yfinance as yf
 from sqlalchemy.orm import Session
 
 from classes.Asset import Asset, DB_Stock, AssetFastInfo, StockResponse
 from models.models import Stock, AssetStatus
-from services.email_service.email_service import send_email_notification
 from services.risk_analysis.analyser import RiskAnalysis
 from services.utils import calculate_shallow_risk_score
 
@@ -39,20 +39,20 @@ def create_stock(db: Session, symbol: str) -> Stock:
             status=AssetStatus.PENDING,
         )
 
-#         # Send email notification
-#         company_name = stock.asset_name
-#         email_subject = f"New Stock Added: {symbol}"
-#         email_message = f"""
-# A new stock has been added to the database:
+        #         # Send email notification
+        #         company_name = stock.asset_name
+        #         email_subject = f"New Stock Added: {symbol}"
+        #         email_message = f"""
+        # A new stock has been added to the database:
 
-# Ticker: {symbol}
-# Name: {company_name}
-# Exchange: {stock.exchange}
+        # Ticker: {symbol}
+        # Name: {company_name}
+        # Exchange: {stock.exchange}
 
-# Initiate the model training process for this stock.
-# Change the status to 'ACTIVE' when ready.
-# """
-#         send_email_notification(email_subject, email_message)
+        # Initiate the model training process for this stock.
+        # Change the status to 'ACTIVE' when ready.
+        # """
+        #         send_email_notification(email_subject, email_message)
 
         db.add(stock)
         db.commit()
@@ -99,8 +99,11 @@ def update_all_stock_risk_scores(db: Session) -> None:
     for stock in stocks:
         try:
             # Get risk score using the analyzer and update it
+            print(f"Updating risk score for {stock.ticker_symbol}...")
             analyser = RiskAnalysis(ticker=str(stock.ticker_symbol), db=db, db_stock=stock)
-            analyser.get_risk_score_and_update()
+            analyser.calculate_overall_risk()
+            print(f"Risk score for {stock.ticker_symbol} updated to {stock.risk_score}")
+            time.sleep(30)  # Pause for 30 seconds to respect API rate limits
         except Exception as e:
             # Log error but continue processing other stocks
             print(f"Error updating risk score for {stock.ticker_symbol}: {str(e)}")

services/risk_analysis/analyser.py

@@ -295,18 +295,4 @@ def get_risk_score_and_update(self) -> RiskScoreUpdate:
         return RiskScoreUpdate(
             risk_score=fast_report["risk_score"],
             was_updated=fast_report["updated"]
-        )
-
-
-# if __name__ == "__main__":
-#     # Example usage
-#     db_gen = get_db()
-#     session = next(db_gen)
-#     try:
-#         analyzer = RiskAnalysis("TSLA", session)
-#         report = analyzer.generate_risk_report(lookback_days=30)
-#         print(report)
-#     except Exception as e:
-#         print(f"Error: {e}")
-#     finally:
-#         session.close()
+        )