Skip to content
This repository has been archived by the owner on Jun 22, 2022. It is now read-only.

Improve mod information discovery #10

Open
Indemnity83 opened this issue Sep 17, 2015 · 2 comments
Open

Improve mod information discovery #10

Indemnity83 opened this issue Sep 17, 2015 · 2 comments
Assignees
Milestone

Comments

@Indemnity83
Copy link
Owner

When attempting to pack Schematica-1.7.10-1.7.6.129-universal.jar I get the following fatal error:

Fatal error: Cannot use object of type stdClass as array in ModCommand.php on line 222

Also, there is no handling for some common, but non-standard mods such as CodeChickenCore which uses a cccmod.info file (for whatever reason). Any others should be added to this thread until its closed then new issues can be opened for other one-off cases which will be evaluated for their legitimacy.

@Indemnity83 Indemnity83 self-assigned this Sep 17, 2015
@EntranceJew
Copy link

This happens because on ModCommand.php#L199 we're trying to get the property $modList->modlist but the correct name for the property is $modList->modList for that file.

@Indemnity83
Copy link
Owner Author

Yeah; I realized that after spending a few minutes in the code; I'm expanding this issue though and improving the handling of the json decode for various situations.

@Indemnity83 Indemnity83 changed the title When packing certain jars, a fatal error is encountered Improve mod information discovery Sep 18, 2015
@Indemnity83 Indemnity83 added this to the 0.2.3 milestone Sep 18, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants