Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression tests for FaparLimitation class #443

Draft
wants to merge 3 commits into
base: issue348_annual_fapar_and_lai
Choose a base branch
from
Draft

Regression tests for FaparLimitation class #443

wants to merge 3 commits into from
+328 −0

Conversation

MarionBWeinzierl
Copy link
Collaborator

@MarionBWeinzierl MarionBWeinzierl commented Mar 3, 2025 •
edited
Loading

Description

This PR adds regression tests for the FaparLimitation class. It adds the functions to create the test data as well as the data, and tests for the FaparLimitation constructor and it's from_pmodel class function.

Fixes #436

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@MarionBWeinzierl MarionBWeinzierl self-assigned this Mar 3, 2025
@MarionBWeinzierl MarionBWeinzierl marked this pull request as draft March 3, 2025 14:34
@MarionBWeinzierl MarionBWeinzierl changed the base branch from develop to issue348_annual_fapar_and_lai March 3, 2025 14:35
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.68%. Comparing base (e8d30f1) to head (bf1e611).

Additional details and impacted files 
@@                        Coverage Diff                        @@
##           issue348_annual_fapar_and_lai     #443      +/-   ##
=================================================================
- Coverage                          94.75%   94.68%   -0.07%     
=================================================================
  Files                                 38       38              
  Lines                               2860     2860              
=================================================================
- Hits                                2710     2708       -2     
- Misses                               150      152       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MarionBWeinzierl MarionBWeinzierl

Labels
testing
Projects
ICCS development board
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create regression test for FaparLimitation class
2 participants
@MarionBWeinzierl @codecov-commenter