Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create regression test for FaparLimitation class #436

Open
6 tasks done
MarionBWeinzierl opened this issue Feb 24, 2025 · 0 comments · May be fixed by #443
Open
6 tasks done

Create regression test for FaparLimitation class #436

MarionBWeinzierl opened this issue Feb 24, 2025 · 0 comments · May be fixed by #443
Assignees

Comments

@MarionBWeinzierl
Copy link
Collaborator

MarionBWeinzierl commented Feb 24, 2025

In #403 , we implemented the FaparLimitation class to calculate LAI fAPAR_max values. We added some unit tests and an example code, but not yet integration/regression tests. This is issue is for implementing those regressions tests. We are doing this by

  • writing out the required annual, already "wrangled" data from the example from Annual fAPAR_max and LAI_max #403 into a netcdf file
  • writing a method to read in the data
  • writing a regression test using the class constructor
  • writing out the data for the from_pmodel class function
  • writing a method to read in the data for from_pmodel
  • writing a regression test using the from_pmodel class function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant