Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check the published implementation of the C3 C4 competition model #388

Open
davidorme opened this issue Jan 13, 2025 · 0 comments
Open

Check the published implementation of the C3 C4 competition model #388

davidorme opened this issue Jan 13, 2025 · 0 comments

Comments

@davidorme
Copy link
Collaborator

davidorme commented Jan 13, 2025

I think there have been some changes in the C3C4Competition between first implementation and publication to reduce the complexity of the tree cover setup. Look at aligning this implementation to the published method.

Although, in practise C3C4Competition is more of a workflow than a coherent Class. Possibly consider exploding into separate functions/classes that can be swapped rather than a monolithic method that is a hostage to fortune.

@davidorme davidorme changed the title Check the published implementation of the C3 C4 competition model - specifically changes to tree cover calculation. Check the published implementation of the C3 C4 competition model Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant