Skip to content

Commit b533033

Browse files
committed
README and a bit of logging in inner DS feature
1 parent 3d5646a commit b533033

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

README.rst

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -695,6 +695,17 @@ example::
695695
coverage report -m
696696

697697

698+
Contributing
699+
============
700+
701+
Please open Issues to start debate regarding the requested
702+
features, or the patch that you would apply. We do not use
703+
a strict submission format, please try to be more concise as possibile.
704+
705+
The Pull Request MUST be done on the dev branch, please don't
706+
push code directly on the master branch.
707+
708+
698709
FAQ
699710
===
700711

djangosaml2/views.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,10 +146,12 @@ def login(request,
146146
kwargs['allow_create'] = "true"
147147

148148
# Do we have a Discovery Service?
149-
discovery_service = getattr(settings, 'SAML2_DISCO_URL', False)
149+
discovery_service = getattr(settings, 'SAML2_DISCO_URL', None)
150150
if discovery_service and not selected_idp:
151151
# We have to build the URL to redirect to with all the information
152152
# for the Discovery Service to know how to send the flow back to us
153+
logger.debug(("A discovery process is needed trough a"
154+
"Discovery Service: {}").format(discovery_service))
153155
login_url = request.build_absolute_uri(reverse('saml2_login'))
154156
login_url = '{0}?next={1}'.format(login_url,
155157
urlquote(came_from, safe=''))
@@ -162,7 +164,7 @@ def login(request,
162164
# is a embedded wayf needed?
163165
idps = available_idps(conf)
164166
if selected_idp is None and len(idps) > 1:
165-
logger.debug('A discovery process is needed')
167+
logger.debug('A discovery process is needed trough WAYF page')
166168
return render(request, wayf_template, {
167169
'available_idps': idps.items(),
168170
'came_from': came_from,

0 commit comments

Comments
 (0)