Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown table text in doc Module too dark in light mode #5320

Closed
martialblog opened this issue Feb 4, 2025 · 1 comment · Fixed by #5332
Closed

Markdown table text in doc Module too dark in light mode #5320

martialblog opened this issue Feb 4, 2025 · 1 comment · Fixed by #5332
Assignees
@martialblog
Labels
area/ui Affects the user interface
Milestone
2.12.3

Comments

@martialblog
Copy link
Member

martialblog commented Feb 4, 2025 •
edited
Loading

Describe the bug

When you create a Markdown table for the doc Module the text is too dark when viewed in light mode.

| Prefix  | Symbol |
|---------|--------|
| Yotta   | Y      |

To Reproduce

Provide a link to a live example, or an unambiguous set of steps to reproduce this issue. Include configuration, logs, etc. to reproduce, if relevant.

  1. Create a Markdown table in doc/
  2. Open the Markdown document with the doc Module
  3. Switch to light mode

Expected behavior

Text color should probably be on the bright side of life OR
the table background should be light instead of dark (probably better since it fits nicer into the light page)

Screenshots

Dark mode:

Image

Light mode:

Image

  • Icinga Web 2 version and modules (System - About): v2.12.2
  • Browser: Firefox 134
@martialblog
Copy link
Member Author

Or maybe the table background should be light instead of dark

@nilmerg nilmerg added the area/ui Affects the user interface label Feb 4, 2025
@nilmerg nilmerg added this to the 2.12.3 milestone Feb 4, 2025
martialblog added a commit to martialblog/icingaweb2 that referenced this issue Mar 5, 2025
@martialblog
Fix doc module markdown table rows in light mode
132a221 
- Replaced the gradient mixin with a simple color
  for odd rows. This fixes and markdown table rows
  in light mode and - since there are very gradients
  in general - it makes the overall look more uniform.

See Icinga#5320
@martialblog martialblog mentioned this issue Mar 5, 2025
Merged
@nilmerg nilmerg assigned nilmerg and martialblog and unassigned nilmerg Mar 20, 2025
nilmerg pushed a commit that referenced this issue Mar 20, 2025
@martialblog @nilmerg
Fix doc module markdown table rows in light mode
6c84530 
- Replaced the gradient mixin with a simple color
  for odd rows. This fixes and markdown table rows
  in light mode and - since there are very gradients
  in general - it makes the overall look more uniform.

See #5320
nilmerg pushed a commit that referenced this issue Mar 25, 2025
@martialblog @nilmerg
Fix doc module markdown table rows in light mode
cb50e33 
- Replaced the gradient mixin with a simple color
  for odd rows. This fixes and markdown table rows
  in light mode and - since there are very gradients
  in general - it makes the overall look more uniform.

See #5320

(cherry picked from commit 6c84530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martialblog martialblog

Labels
area/ui Affects the user interface
Projects
None yet
Milestone
2.12.3
Development

Successfully merging a pull request may close this issue.

Fix doc module markdown table rows in light mode martialblog/icingaweb2
2 participants
@martialblog @nilmerg