-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define BlockedTuple
#9
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
==========================================
+ Coverage 0.00% 85.71% +85.71%
==========================================
Files 12 16 +4
Lines 284 336 +52
==========================================
+ Hits 0 288 +288
+ Misses 284 48 -236
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ogauthe related to the discussions about type stability, can you add tests for type stability? You can use |
@ogauthe thanks for rewriting in terms of |
Looks great, thanks! This will be very useful, it will be nice to use this to simplify the implementation of @lkdvos if you have time could you look into the remaining type instabilities? I imagine it shouldn't be too hard to fix those either by tweaking the code, adding |
This PR defines
BlockedTuple
, a Tuple of Tuple like structure with aBlockArrays.jl
interface. Data is stored as one flat tuple, with divisions stored as a type parameter (as opposed to storing N tuples).