Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make an eigendecomp function #341

Open
mtfishman opened this issue May 4, 2020 · 1 comment
Open

Make an eigendecomp function #341

mtfishman opened this issue May 4, 2020 · 1 comment
Assignees
Labels
decompositions Issues related to tensor decompositions. enhancement New feature or request
Milestone

Comments

@mtfishman
Copy link
Member

To complement the new eigen interface introduced in #334, it may be nice to have another function, possibly call eigendecomp, that returns a factorization of an ITensor in terms of left and right eigenvectors and the eigenvalues:

i = Index(2)
A = randomITensor(i', i)
V, D, W = eigendecomp(A)
A == V * D * W

Here, V stores the right eigenvectors of A and W stores the left eigenvectors. In the case of a Hermitian A, W would be related to the complex conjugation of V. More generally, W is related to the matrix inverse of V.

This could mostly be written as a wrapper around eigen, where in the non-Hermitian case it could do two calls to eigen to get the left and right eigenvectors (and do some extra normalization of the sets of left and right eigenvectors).

I think it is useful to have both eigen and eigendecomp, where sometimes just the right or left eigenvectors are desired, while other times it is nice to have a full factorization that can easily reproduce the original ITensor (for example think about using it in a tensor renormalization algorithm like TRG or CTMRG, where you want to get a factorized replacement for a tensor in the network).

@emstoudenmire
Copy link
Collaborator

Sounds like a great idea

@mtfishman mtfishman self-assigned this Oct 8, 2020
@mtfishman mtfishman added this to the v0.3 milestone Oct 8, 2020
@mtfishman mtfishman added decompositions Issues related to tensor decompositions. enhancement New feature or request labels Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
decompositions Issues related to tensor decompositions. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants