Skip to content

Create an iterator interface for alternating_update #200

@mtfishman

Description

@mtfishman

An iterator interface for alternating_update could allow advanced users more fine-grained control over iterating through region updates and sweeps, for example allow them to change the sweep pattern based on the current state of the solver, perform custom printing, move objects back and forth between different devices (i.e. CPU, GPU, disk, etc.) based on properties of the current state, etc.

Additionally, higher level function interfaces like alternating_update can be implemented as loops over those iterators, which could improve the code logic.

For example, alternating_update could be implemented like this:

sweep_iterator = AlternatingUpdateIterator(projected_operator, init_state, sweep_plans)
for (; region_iterator, which_sweep) in sweep_iterator # Iterate over sweep updates
  @show which_sweep # Custom printing
  for (; state, region) in region_iterator # Iterate over the region updates of the sweep
    @show region # More custom printing
    # Perform some logic, like if maxlinkdim(state) > 1000, move from GPU to CPU
    if maxlinkdim(state) > 1000
      sweep_iterator.state = cpu(state)
    end
  end
end

That's just a rough outline and example, I'm sure the interface won't be exactly like that.

This design approach could also help us rethink the sweep plan logic, which is a bit of a mess right now, and we'll also have to think about how it interfaces with the observer system (I think it fits in well, and would allow users to inject calls to the observer in a more custom way, while right now the calls are hardcoded at certain points in the code logic).

See these references for examples of iterative algorithms based around iterators:
https://docs.sciml.ai/DiffEqDocs/stable/basics/integrator
https://iterativesolvers.julialinearalgebra.org/dev/iterators
https://discourse.julialang.org/t/ann-optimkit-jl-a-blissfully-ignorant-julia-package-for-gradient-optimization/41063/3

@emstoudenmire @JoeyT1994

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions