Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMU: Enhanced cryostat control scripts #6729

Closed
6 of 7 tasks
JamesKingWork opened this issue Aug 17, 2021 · 8 comments
Closed
6 of 7 tasks

EMU: Enhanced cryostat control scripts #6729

JamesKingWork opened this issue Aug 17, 2021 · 8 comments
Assignees
Labels
3 no_release_notes Tickets that do not need release notes, use sparingly!

Comments

@JamesKingWork
Copy link
Contributor

JamesKingWork commented Aug 17, 2021

As an instrument scientist and user on EMU, I need enhanced cryostat control scripts, so that systems running under pressure control will heat and cool automatically to the desired temperature, automatically adjusting the gas flow and heater for optimal running. This ticket is to sit down with EMU scientists and gather requirements, agree on an appropriate algorithm. A ticket should be spun off to test the scripts when complete and will be carried out with other testing after the migration of EMU to Windows 10.

Acceptance criteria:

  • Requirements are gather for the enhanced scripts
  • Algorithm and design decided upon
    • Dev manual page describing the problem and design complete
    • OPI design is on a branch
    • Flowchart describes desired behaviour
    • Example lookup table is produced
  • Ticket to implement is created and linked

Notes

  • We should agree at this point exact numbers so requirements don't keep growing
@JamesKingWork JamesKingWork changed the title EMU: Enhance cryostat control scripts EMU: Enhanced cryostat control scripts Aug 17, 2021
@JamesKingWork
Copy link
Contributor Author

Have a look at the little blue cryostat for refl

@DominicOram
Copy link
Contributor

Cryogenics team should be in the meeting too

@JamesKingWork
Copy link
Contributor Author

Meeting scheduled for the 3rd of November

@JamesKingWork
Copy link
Contributor Author

Meeting has been had with me, @KathrynBaker, @rerpha, the EMU team and a member of the cryo team. The cryo team will send some more details and I will write up a design from it and present it to the group.

@JamesKingWork
Copy link
Contributor Author

Design for UI of enhanced mercury cryostat control: ISISComputingGroup/ibex_gui#1374

@JamesKingWork JamesKingWork added 3 and removed 8 labels Nov 17, 2021
@RaiBishal RaiBishal removed this from the SPRINT_2021_10_28 milestone Nov 18, 2021
@JamesKingWork
Copy link
Contributor Author

JamesKingWork commented Nov 22, 2021

Updated design based on scientists and cryo feedback at https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/MercuryiTC-Enhanced-Cryostat-Control with test script written in Settings/config/NDXEMU/Python/inst under the name cryo_control_test.py. Now waiting on scientist replies and organisation of testing. I think this testing should be spun off into another ticket but I'll leave that up to @rerpha who will take over at the end of this week,

@JamesKingWork
Copy link
Contributor Author

Putting this into review, cryogenics have confirmed that the algorithm looks good

@KathrynBaker
Copy link
Member

The scientists confirmed that the tests were complete and the test script worked well with a few adjustments for the whole temperature range, as such the system can now be incorporated into IBEX. I have created #6947 to complete this work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 no_release_notes Tickets that do not need release notes, use sparingly!
Projects
None yet
Development

No branches or pull requests

5 participants