Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrums should include parent nav item #35

Closed
dayotte opened this issue Nov 21, 2024 · 6 comments
Closed

Breadcrums should include parent nav item #35

dayotte opened this issue Nov 21, 2024 · 6 comments

Comments

@dayotte
Copy link
Collaborator

dayotte commented Nov 21, 2024

When on a subpage of About or Explore the breadcrumbs should include the parent nav item, e.g.:
Home > Explore > Browse all Species, rather than Home > Browse all Species.

image

@amb26
Copy link
Member

amb26 commented Dec 4, 2024

An issue with this is that we don't actually have an "explore" page on the site for the breadcrumb level to refer to with a link and so what we get is the "Explore" level of containment seems to fall onto the first subpage instead, "Browse All Species", see if you think this is acceptable ....

@dayotte
Copy link
Collaborator Author

dayotte commented Dec 5, 2024

@amb26 I know we can't link to the parent page (because there isn't one), but can we just show it in the breadcrumb path? Hope that makes sense.

@amb26
Copy link
Member

amb26 commented Dec 10, 2024

Yes this should now be done, please check over the sites

@dayotte
Copy link
Collaborator Author

dayotte commented Dec 10, 2024

Thanks @amb26. Can we remove the links to the "parent" page in the breadcrumbs? If I select it it takes me back to the first child page on the drop down list which is confusing. We don't need that to be a link at all. The current page in the breadcrumb is also a link right now (linking to itself). Can we remove that link too? Thanks for adding the current page indicator bars!

@amb26
Copy link
Member

amb26 commented Dec 10, 2024

OK, I have had a go at this. Quarto doesn't let this be configured so I have had to hack it.

@dayotte
Copy link
Collaborator Author

dayotte commented Dec 11, 2024

Perfect @amb26! Thank you!

@amb26 amb26 closed this as completed Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants