Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #261: Annotation with a Non-Rectangular Polygon (update) #115

Open
glenrobson opened this issue Jul 13, 2023 · 4 comments
Open

Recipe #261: Annotation with a Non-Rectangular Polygon (update) #115

glenrobson opened this issue Jul 13, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This is an update to the recipe approved in #80. The update was requested as it was felt the recipe allowed too many options for the SVG which would make it difficult to implement. The update tries to put some bounds on the type of SVG that a client would support. You can see the specific changes to the recipe in this diff:

https://github.com/IIIF/cookbook-recipes/pull/321/files

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

@glenrobson glenrobson added this to the July 2023 milestone Jul 13, 2023
@triplingual
Copy link

triplingual commented Jul 19, 2023

(Yikes! I see that manifest highlighting was not in the original and still isn't in this one. Noting here that I'll add it to bring forward visually the JSON specific to an SVG Annotation.)

@triplingual
Copy link

Also noting, as is my wont, that I upvoted my own recipe.

@triplingual
Copy link

Highlighting added!

@glenrobson
Copy link
Member Author

Issue 115 (Recipe #261: Annotation with a Non-Rectangular Polygon (update))

+1: 15 [akrishnan15 cubap danieltbrennan eliotjordan glenrobson hadro ioanrichards julsraemy kirschbombe ksclarke markpbaggett nfreire regisrob triplingual zimeon]
0: 0 []
-1: 0 []
Not TRC: 0 []
Ineligible: 0 []

Result: 15 / 15 = 1.00

Super majority is in favor, issue is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants