Removed template_file data to support ARM in GCP (#628)

Signed-off-by: HareshKumarkj <[email protected]>

Author: HareshKumarkj

resources/gcp/compute/vm_instance_0_disk/vm_instance_0_disk.tf

@@ -42,13 +42,13 @@ data "google_compute_machine_types" "itself" {
   zone   = var.zone
 }
 
-data "template_file" "metadata_startup_script" {
-  template = <<EOF
-#!/usr/bin/env bash
-echo "${var.private_key_content}" > ~/.ssh/id_rsa
-chmod 600 ~/.ssh/id_rsa
-echo "StrictHostKeyChecking no" >> ~/.ssh/config
-EOF
+locals {
+  user_data = <<-EOT
+    #!/usr/bin/env bash
+    echo "${var.private_key_content}" > ~/.ssh/id_rsa
+    chmod 600 ~/.ssh/id_rsa
+    echo "StrictHostKeyChecking no" >> ~/.ssh/config
+  EOT
 }
 
 #tfsec:ignore:google-compute-enable-shielded-vm-im
@@ -90,7 +90,7 @@ resource "google_compute_instance" "itself" {
     vmdnssetting           = var.is_multizone ? "GlobalDefault" : "ZonalOnly"
   }
 
-  metadata_startup_script = data.template_file.metadata_startup_script.rendered
+  metadata_startup_script = local.user_data
 
   service_account {
     email  = var.service_email

resources/gcp/compute/vm_instance_ip_fwd/vm_instance_ip_fwd.tf

@@ -43,15 +43,16 @@ data "google_kms_crypto_key" "itself" {
   key_ring = data.google_kms_key_ring.itself[0].id
 }
 
-data "template_file" "metadata_startup_script" {
-  template = <<EOF
-#!/usr/bin/env bash
-echo "${var.private_key_content}" > ~/.ssh/id_rsa
-chmod 600 ~/.ssh/id_rsa
-echo "StrictHostKeyChecking no" >> ~/.ssh/config
-echo "net.ipv4.ip_forward = 1" >> /etc/sysctl.conf
-sysctl -p
-EOF
+
+locals {
+  user_data = <<-EOT
+    #!/usr/bin/env bash
+    echo "${var.private_key_content}" > ~/.ssh/id_rsa
+    chmod 600 ~/.ssh/id_rsa
+    echo "StrictHostKeyChecking no" >> ~/.ssh/config
+    echo "net.ipv4.ip_forward = 1" >> /etc/sysctl.conf
+    sysctl -p
+  EOT
 }
 
 #tfsec:ignore:AVD-GCP-0067
@@ -95,7 +96,7 @@ resource "google_compute_instance" "itself" {
     vmdnssetting           = var.is_multizone ? "GlobalDefault" : "ZonalOnly"
   }
 
-  metadata_startup_script = data.template_file.metadata_startup_script.rendered
+  metadata_startup_script = local.user_data
 
   service_account {
     email  = var.service_email

resources/gcp/compute/vm_instance_multiple_disk/vm_instance_multiple_disk.tf

@@ -41,30 +41,30 @@ data "google_kms_crypto_key" "itself" {
   key_ring = data.google_kms_key_ring.itself[0].id
 }
 
-data "template_file" "metadata_startup_script" {
-  template = <<EOF
-#!/usr/bin/env bash
-echo "${var.private_key_content}" > ~/.ssh/id_rsa
-chmod 600 ~/.ssh/id_rsa
-echo "StrictHostKeyChecking no" >> ~/.ssh/config
-if [ ! -d "/var/mmfs/etc" ]; then
-   mkdir -p "/var/mmfs/etc"
-fi
-echo "#!/bin/ksh" > "/var/mmfs/etc/nsddevices"
-echo "# Generated by IBM Storage Scale deployment." >> "/var/mmfs/etc/nsddevices"
-%{if length(var.disk) > 0}
-  %{for key, value in var.disk~}
-    echo "echo \"disk/by-id/google-${key} generic\"" >> "/var/mmfs/etc/nsddevices"
-  %{endfor~}
-%{else}
-  %{for key in range(var.total_local_ssd_disks)~}
-    echo "echo \"disk/by-id/google-local-nvme-ssd-${key} generic\"" >> "/var/mmfs/etc/nsddevices"
-  %{endfor~}
-%{endif}
-echo "# Bypass the NSD device discovery" >> "/var/mmfs/etc/nsddevices"
-echo "return 0" >> "/var/mmfs/etc/nsddevices"
-chmod u+x "/var/mmfs/etc/nsddevices"
-EOF
+locals {
+  user_data = <<-EOT
+    #!/usr/bin/env bash
+    echo "${var.private_key_content}" > ~/.ssh/id_rsa
+    chmod 600 ~/.ssh/id_rsa
+    echo "StrictHostKeyChecking no" >> ~/.ssh/config
+    if [ ! -d "/var/mmfs/etc" ]; then
+       mkdir -p "/var/mmfs/etc"
+    fi
+    echo "#!/bin/ksh" > "/var/mmfs/etc/nsddevices"
+    echo "# Generated by IBM Storage Scale deployment." >> "/var/mmfs/etc/nsddevices"
+    %{if length(var.disk) > 0}
+      %{for key, value in var.disk~}
+        echo "echo \"disk/by-id/google-${key} generic\"" >> "/var/mmfs/etc/nsddevices"
+      %{endfor~}
+    %{else}
+      %{for key in range(var.total_local_ssd_disks)~}
+        echo "echo \"disk/by-id/google-local-nvme-ssd-${key} generic\"" >> "/var/mmfs/etc/nsddevices"
+      %{endfor~}
+    %{endif}
+    echo "# Bypass the NSD device discovery" >> "/var/mmfs/etc/nsddevices"
+    echo "return 0" >> "/var/mmfs/etc/nsddevices"
+    chmod u+x "/var/mmfs/etc/nsddevices"
+  EOT
 }
 
 #tfsec:ignore:google-compute-enable-shielded-vm-im
@@ -115,7 +115,7 @@ resource "google_compute_instance" "itself" {
     vmdnssetting           = var.is_multizone ? "GlobalDefault" : "ZonalOnly"
   }
 
-  metadata_startup_script = data.template_file.metadata_startup_script.rendered
+  metadata_startup_script = local.user_data
 
   service_account {
     email  = var.service_email