-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HAP transform: Update README.md and add sample notebook #821
Conversation
update readme for hap transform
Thank you, @ian-cho. The README looks good. Three requests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments.
Sorry, @ian-cho. After I gave you the links to the branch above, the branch was merged, so the new links are in the dev branch at: |
1. added contributor 2. added hap notebook
@shahrokhDaijavad Hi, I updated the PR as requested. Please review, thanks.
|
@@ -48,6 +56,20 @@ python hap_local_python.py | |||
|
|||
You will obtain the output file `test1.parquet` in the output directory. | |||
|
|||
### Code example | |||
[notebook](../hap_python.ipynb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link to the notebook is broken. The correct link is: ./hap_python.ipynb, because the notebook is in the python directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @ian-cho, for developing the minimal notebook that is functionally correct. For the consistency of your notebook with others, before the current cell one that imports the necessary packages, can you please add what we add in other notebooks, similar to what is here: https://github.com/IBM/data-prep-kit/blob/dev/transforms/language/doc_quality/doc_quality.ipynb?
@shahrokhDaijavad Thank you for further suggestions. Before code cells, I added markdown content and configurations for the hap transforms just as doc_quality.ipynb did. Please review. |
Thank you, @ian-cho. The notebook looks good. And what about the broken link in the README above? |
@shahrokhDaijavad Sorry, I missed that. Fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you, @ian-cho.
Signed-off-by: Maroun Touma <[email protected]>
update readme for hap transform
Related issue number (if any).
#753