-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restructure Pdf2Parquet with its own dpk_ namespace #813
Conversation
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@touma-I thank you for your work.
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: SHAHROKH DAIJAVAD <[email protected]>
@touma-I Please check what I have done before I make changes to the others. You seem to have only the run-cli-sample as a target for |
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: Maroun Touma <[email protected]>
Signed-off-by: matouma <[email protected]>
Signed-off-by: matouma <[email protected]>
Why are these changes needed?
This is a first of a series of restructuring changes that are done to have each transform built as its own module (e.g. dpk_pdf2parquet) with a ray submodule (dpk_pdf2parquet.ray ).
Removed python and ray folders and keep Dockerfile.python and Dockerfile.ray
remove pyproject.toml and Makefiles
move python code under dpk_pdf2parquet
move ray code under dpk_pdf2parquet/ray
change import statement to include module name
replace recursive Makefile and use targets from .make.cicd.targets
adapt kfp_ray/Makefile and other make target
Related issue number (if any).
#774