Fix kfp workflows which were created with a bad template #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
daw3rd
commented
Oct 5, 2024
| @@ -9,7 +9,7 @@ define set_env_var | |||
| endef | |||
|
|
|||
|
|
|||
| KFP_ENDPOINT ?= "http://localhost:8080/" | |||
| KFP_ENDPOINT?="http://localhost:8080/" | |||
There was a problem hiding this comment.
this change is only to trigger the transform kfp tests.
daw3rd
commented
Oct 5, 2024
| # repo_level_order parameters | ||
| repo_lvl_stage_one_only: bool = False, | ||
| repo_lvl_grouping_column: str = "repo_name", | ||
| repo_lvl_store_type: str = "ray", | ||
| repo_lvl_store_backend_dir: str = "", | ||
| repo_lvl_store_ray_cpus: float = "0.5", | ||
| repo_lvl_store_ray_cpus: float = 0.5, |
There was a problem hiding this comment.
Most of the other changes here were pre-commit cleanups, but this one seems like a real bug fix.
There was a problem hiding this comment.
yes, it was and it's fixed in #619
Signed-off-by: David Wood <[email protected]>
roytman
reviewed
Oct 6, 2024
| timeout-minutes: 120 | ||
| run: | | ||
| if [ -e "@TARGET_TRANSFORM_DIR/Makefile" -a -d "@TARGET_TRANSFORM_DIR/kfp_ray" ]; then | ||
| if [ -e "transforms/code/code2parquet/Makefile" -a -e "transforms/code/code2parquet/kfp_ray/Makefile" ]; then |
There was a problem hiding this comment.
can we combine the lines 62-86 in a shared Make rule, which will be the same for all transformers, and just change its arguments?
There was a problem hiding this comment.
100% agree with this, but can I put that on @revit13 for another PR.
revit13
approved these changes
Oct 6, 2024
|
@daw3rd according to https://github.com/IBM/data-prep-kit/actions/runs/11193934073/job/31119824449 it seems header_cleanser should be added to the kfp black list. |
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Why are these changes needed?
To enable kfp tests across all transforms (likely for the first time).
Related issue number (if any).