Move transform version numbers out of .make.versions to transform-specific file #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
…nd fdedup Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
Signed-off-by: David Wood <[email protected]>
touma-I
reviewed
Oct 8, 2024
| # | ||
| # If you change the versions numbers, be sure to run "make set-versions" to | ||
| # update version numbers across the transform (e.g., pyproject.toml). | ||
| CODE2PARQUET_PYTHON_VERSION=$(DPK_VERSION) |
There was a problem hiding this comment.
@daw3rd How are we getting DPK_VERSION if we are not including .make.versions ?
There was a problem hiding this comment.
The transformer Makefiles include $(REPOROOT)/transforms/.make.transforms it includes $(REPOROOT)/.make.defaults and the last one includes $(REPOROOT)/.make.versions
|
@daw3rd scripts/transforms/update_workflow_tags.sh needs to be update to take the versions from the config files. |
roytman
approved these changes
Oct 9, 2024
| # | ||
| # If you change the versions numbers, be sure to run "make set-versions" to | ||
| # update version numbers across the transform (e.g., pyproject.toml). | ||
| CODE2PARQUET_PYTHON_VERSION=$(DPK_VERSION) |
There was a problem hiding this comment.
The transformer Makefiles include $(REPOROOT)/transforms/.make.transforms it includes $(REPOROOT)/.make.defaults and the last one includes $(REPOROOT)/.make.versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Why are these changes needed?
Per issue #639 we would like to allow transforms to update their own version numbers.
However we don't want such a change to trigger ci/cd on all other transforms.
As such we need to move the version number out of .make.versions to a file that is more local to the transform.
Note that this is only the first of the TODOs listed in issue #639, but can be done independent of the others.
Related issue number (if any).
#639