Skip to content

Commit 156dfec

Browse files
committed
additional testing
1 parent d44d552 commit 156dfec

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

data-processing-lib/ray/src/data_processing_ray/runtime/ray/ray_utils.py

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,11 @@
1111
################################################################################
1212

1313
import logging
14-
import sys
1514
import time
1615
from typing import Any
1716

1817
import ray
18+
from ray.experimental.state.api import list_actors
1919
from data_processing.utils import GB, UnrecoverableException
2020
from ray.actor import ActorHandle
2121
from ray.exceptions import RayError
@@ -109,7 +109,14 @@ def operator() -> ActorHandle:
109109
time.sleep(creation_delay)
110110
return clazz.options(**actor_options).remote(params)
111111

112-
return [operator() for _ in range(n_actors)]
112+
cls_name = clazz.__class__.__name__.replace('ActorClass(', '').replace(')','')
113+
actors = [operator() for _ in range(n_actors)]
114+
time.sleep(1)
115+
alive = list_actors(filters=[("class_name", "=", cls_name), ("state", "=", "ALIVE")])
116+
if len(actors) == len(alive):
117+
return actors
118+
print(f"created {actors}, alive {alive}")
119+
raise UnrecoverableException(f"out of {len(actors)} created classes only {len(alive)} alive")
113120

114121
@staticmethod
115122
def process_files(
@@ -220,6 +227,7 @@ def process_files(
220227
def wait_for_execution_completion(logger: logging.Logger, replies: list[ray.ObjectRef]) -> int:
221228
"""
222229
Wait for all requests completed
230+
:param logger: logger to use
223231
:param replies: list of request futures
224232
:return: None
225233
"""

transforms/universal/noop/ray/src/noop_transform_ray.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# limitations under the License.
1111
################################################################################
1212

13-
from data_processing.utils import CLIArgumentProvider, get_logger
13+
from data_processing.utils import get_logger
1414
from data_processing_ray.runtime.ray import RayTransformLauncher
1515
from data_processing_ray.runtime.ray.runtime_configuration import (
1616
RayTransformRuntimeConfiguration,
@@ -31,7 +31,6 @@ class NOOPRayTransformConfiguration(RayTransformRuntimeConfiguration):
3131
def __init__(self):
3232
"""
3333
Initialization
34-
:param base_configuration - base configuration class
3534
"""
3635
super().__init__(transform_config=NOOPTransformConfiguration())
3736

0 commit comments

Comments
 (0)