Merge pull request #28 from IBM/fix-pep-508

add deps pyproject

Author: jubueche

.github/workflows/commit_check.yml

@@ -15,21 +15,19 @@ jobs:
     - uses: actions/checkout@v4
       with:
         fetch-depth: 0  # Get full git history
-    - name: Install package
-      run: |
-        pip install --upgrade pip
-        pip install -e .
     - name: Set up Python
       uses: actions/setup-python@v5
       with:
         python-version: '3.10.17'
-    - name: Install dependencies
+    - name: Install package
       run: |
-        python -m pip install --upgrade pip
-        pip install -r requirements_dev.txt
-        pip install torch torchvision torchaudio --index-url https://download.pytorch.org/whl/cpu
+        pip install --upgrade pip
+        pip install uv
+        uv venv --python 3.10.17
+        uv pip install -e ".[dev]" --torch-backend=auto
     - name: Pytest
       run: |
+        source .venv/bin/activate
         make pylint
         make pycodestyle
         make mypy

examples/deepspeed_and_huggingface/utils.py

@@ -23,7 +23,7 @@
 from aihwkit_lightning.exceptions import ArgumentError
 
 
-class CustomTrainer(Trainer):
+class CustomTrainer(Trainer):  # pylint: disable=too-few-public-methods
     """Custom trainer handling weight clipping."""
 
     # overwriting for clipping the weights
@@ -117,7 +117,7 @@ def create_rpu_config(args):
     return rpu_config
 
 
-class PrettySafeLoader(yaml.SafeLoader):
+class PrettySafeLoader(yaml.SafeLoader):  # pylint: disable=too-few-public-methods
     """Allows specifying tuples in yaml config."""
 
     def construct_python_tuple(self, node):

pyproject.toml

@@ -1,5 +1,6 @@
 [build-system]
-requires = ["setuptools"]
+requires = ["setuptools>=61.0", "wheel"]
+build-backend = "setuptools.build_meta"
 
 [project]
 requires-python = ">= 3.8"
@@ -16,7 +17,12 @@ maintainers = [
 description = "IBM Analog Hardware Acceleration Kit - Lightning"
 readme = "README.md"
 license = "MIT"
-license-files = ["LICENCSE.TXT"]
+license-files = ["LICENSE.txt"]
+dependencies = [
+    "torch>=1.10.0",
+    "typing_extensions>=4.0.0",
+    "tqdm",
+]
 keywords = [
     "ai",
     "analog",
@@ -32,9 +38,33 @@ keywords = [
     "non-volatile memory",
     "phase-change material"
 ]
+[project.optional-dependencies]
+dev = [
+    "mypy==1.8.0",
+    "pylint==2.15.7",
+    "pycodestyle==2.11.1",
+    "black==24.3.0",
+    "pytest",
+]
+huggingface = [
+    "transformers>=4.20.0",
+    "datasets",
+]
+triton = [
+    "triton>=2.0.0",
+]
+
 [project.urls]
 Paper = "https://openreview.net/forum?id=QNdxOgGmhR"
 Documentation = "https://aihwkit-lightning.readthedocs.io/en/latest/"
 Repository = "https://github.com/IBM/aihwkit-lightning"
 Issues = "https://github.com/IBM/aihwkit-lightning/issues"
-Changelog = "https://github.com/IBM/aihwkit-lightning/blob/main/CHANGELOG.md"
+Changelog = "https://github.com/IBM/aihwkit-lightning/blob/main/CHANGELOG.md"
+
+[tool.setuptools.packages.find]
+where = ["src"]
+
+[tool.mypy]
+ignore_missing_imports = true
+disable_error_code = ["operator", "index", "union-attr"]
+

tests/test_post_training_weight_quantization.py

@@ -106,9 +106,7 @@ def test_post_training_weight_quantization(
     analog_model = convert_to_analog(model, rpu_config=rpu_config)
 
     # create an analog optimizer
-    optim = AnalogOptimizer(
-        AdamW, analog_model.analog_layers, analog_model.parameters(), lr=0.001
-    )
+    optim = AnalogOptimizer(AdamW, analog_model.analog_layers, analog_model.parameters(), lr=0.001)
     for _ in range(1):
         optim.zero_grad()
         out = analog_model(inp)