-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HotSwap recompiles all classes every time and compilation is in general slow #11
Comments
Yep, happened for me too when I used this tool. It's not really maintained by me unless it's a version bump as I have other projects (not on GitHub) I'm working on, and school. This is GitHub, so of course if you know how to fix it, you can submit a pull request to fix it, and I'll merge it. |
I don't know how to fix this anyway as this is just a Gradle script that uses ForgeGradle to decompile and recompile Minecraft, this just allows you to edit raw Minecraft code instead of making a Forge mod. |
Matter of fact, I'll put my side project (a chat app) on GitHub soon so others can help after I figure out the license I want. |
@FTC55 try this method https://github.com/hypercubemc-github/Modern-Minecraft-Decompiler/wiki/Running-the-Client-in-the-IDE#method-3--not-recommended- PS:if doesn't work try the method 1. |
@ahmed605 Unfortunately it didn't work. Is there a way for me to compile everything with the built in compiler instead of gradle? I think that could help. |
@FTC55 the method that I sent (method 3) uses the IntelliJ compiler and not the gradle one and it's working for me, maybe you didn't chose the new configuration and you used the old one accidentally |
@ahmed605 Either I misunderstood the procedure or it just doesn't work. I made sure i used the new config i had created following method 3 and still it was clearly compiling using gradle as the log said :compileJava and "starting Gradle daemon" |
Did anybody fix it? |
@7isenko i enabled gradle caching, incremental compilation and parallel execution and that seems to speed it up a bit |
@7isenko |
Hi, I have an issue with the tool in IntelliJ. Whenever i modify the code and then compile it with CTRL+SHIFT+F9 while the client is running not only does it take a very long time to recompile (just like it does to compile everytime even when you're not actually hotswapping while the client is running so the issues might be related), but I can also see that even if i only apply changes to one class, all of the classes are reloaded which also takes an incredible amount of time. My guess would be that there is something that tries to compile everything everytime no matter what, even if only a small modification was made to the code.
The text was updated successfully, but these errors were encountered: